Prevent users from seeing notifications for their own access request #49915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielcorado
approved these changes
Dec 7, 2024
hugoShaka
approved these changes
Dec 9, 2024
rudream
force-pushed
the
yassine/fix-access-request-notif
branch
from
f7525f6 to
37c9b9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR resolves #49457
This PR fixes a bug where in cases where a user has the permissions to review requests for the roles/resources they themselves requested, they will receive a notification for their own access request.
Global notifications now have an
ExcludeUsersfield which can be used to explicitly exclude certain specific users from a receiving global notification.changelog: Fixed bug causing users to see notifications for their own access requests in some cases