Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert lib/srv to use slog #49913

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Convert lib/srv to use slog #49913

merged 1 commit into from
Dec 11, 2024

Conversation

rosstimothy
Copy link
Contributor

This migrates the rest of the srv package to use slog for logging. Most sub-packages still however rely on logrus.

@rosstimothy rosstimothy added the no-changelog Indicates that a PR does not require a changelog entry label Dec 6, 2024
@rosstimothy rosstimothy force-pushed the tross/srv_ctx_slog branch 2 times, most recently from 9bd0604 to 84817ec Compare December 9, 2024 14:57
This migrates the rest of the srv package to use slog for logging.
Most sub-packages still however rely on logrus.
@rosstimothy rosstimothy marked this pull request as ready for review December 10, 2024 14:15
@rosstimothy
Copy link
Contributor Author

@zmb3 @r0mant could I trouble either of you for a flaky bypass here? I've altered the logger used in to many existing slow tests which is preventing the job from completing in 10m.

@zmb3
Copy link
Collaborator

zmb3 commented Dec 11, 2024

/excludeflake *

@rosstimothy rosstimothy added this pull request to the merge queue Dec 11, 2024
Merged via the queue into master with commit a191cc1 Dec 11, 2024
43 checks passed
@rosstimothy rosstimothy deleted the tross/srv_ctx_slog branch December 11, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants