Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the decisionv1.Service boilerplate #49912

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

codingllama
Copy link
Contributor

Add the gRPC boilerplate, wires service and client and adds a simple test.

#49837

@codingllama codingllama added the no-changelog Indicates that a PR does not require a changelog entry label Dec 6, 2024
@codingllama
Copy link
Contributor Author

@codingllama
Copy link
Contributor Author

Friendly ping @rosstimothy @fspmarshall.

Base automatically changed from codingllama/pdp-protos to master December 16, 2024 18:38
@codingllama codingllama force-pushed the codingllama/pdp-skeleton branch from 6ff4847 to 0fb1117 Compare December 16, 2024 20:49
@codingllama
Copy link
Contributor Author

Friendly ping reviewers? The base has landed so this is now free to be merged as well (pending review, ofc).

@codingllama
Copy link
Contributor Author

FYI @fspmarshall I'll go ahead and merge this. If you have comments let me know and I'll address them in a follow up.

@codingllama codingllama added this pull request to the merge queue Dec 17, 2024
Merged via the queue into master with commit 0aaca3f Dec 17, 2024
42 checks passed
@codingllama codingllama deleted the codingllama/pdp-skeleton branch December 17, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants