Disable file transfer buttons if user lacks permissions #49892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will disable the upload/download buttons in the web terminal if the user does not have the role option `ssh_file_copy`
avatus
added
backport-required
no-changelog
zmb3
approved these changes
Dec 6, 2024
avatus
commented
Dec 6, 2024
|
|
||
| import DocumentSsh from '.'; | ||
|
|
||
| test('file transfer buttons are disabled if user does not have access', async () => { |
There was a problem hiding this comment.
this component didn't have any tests at all previously. I've created the tests file and only added tests relevant to this PR
avatus
added a commit
that referenced
this pull request
Dec 6, 2024
Backport #49892 Manual backport due to all the changes that have happened to roles lately (and some missing components)
flyinghermit
approved these changes
Dec 6, 2024
public-teleport-github-review-bot
bot
removed the request for review
from ryanclark
avatus
added a commit
that referenced
this pull request
Dec 9, 2024
This will disable the upload/download buttons in the web terminal if the user does not have the role option `ssh_file_copy`
avatus
added a commit
that referenced
this pull request
Dec 9, 2024
This will disable the upload/download buttons in the web terminal if the user does not have the role option `ssh_file_copy`
avatus
added a commit
that referenced
this pull request
Dec 9, 2024
This will disable the upload/download buttons in the web terminal if the user does not have the role option `ssh_file_copy`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will disable the upload/download buttons in the web terminal if the user does not have the role option
ssh_file_copyFixes: #26235
I have intentionally not fixed in Connect yet because the ACL changes there are bit more involved and I think warrants a separate PR.