-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UserTasks for DiscoverEKS Issues - proto #49887
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
no-changelog
Indicates that a PR does not require a changelog entry
backport/branch/v16
backport/branch/v17
labels
Dec 6, 2024
ryanclark
approved these changes
Dec 9, 2024
marcoandredinis
force-pushed
the
marco/usertasks_discovereks_proto
branch
from
December 9, 2024 11:45
e689166
to
09f9ae6
Compare
@kiosion Can you please take a look when you get a chance? |
marcoandredinis
force-pushed
the
marco/usertasks_discovereks_proto
branch
3 times, most recently
from
December 11, 2024 08:49
b841ab3
to
b7a9d46
Compare
strideynet
approved these changes
Dec 11, 2024
tigrato
approved these changes
Dec 11, 2024
public-teleport-github-review-bot
bot
removed the request for review
from kiosion
December 11, 2024 10:16
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Dec 11, 2024
marcoandredinis
force-pushed
the
marco/usertasks_discovereks_proto
branch
from
December 11, 2024 10:29
b7a9d46
to
dbf3063
Compare
marcoandredinis
force-pushed
the
marco/usertasks_discovereks_proto
branch
from
December 11, 2024 10:31
dbf3063
to
0e77b4d
Compare
@marcoandredinis See the table below for backport results.
|
marcoandredinis
added a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the proto messages required to start emitting UserTasks for DiscoverEKS issues.
What are UserTasks?
UserTasks are work items created to let the user know of failures that occured when trying to run Auto Discover processes. When something fails it will create a UserTask with as much detail as possible. The user is then notified of a new UserTask, and can act upon it.