Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky TestAutoUpdateAgentShouldUpdate #49883

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

hugoShaka
Copy link
Contributor

@hugoShaka hugoShaka commented Dec 6, 2024

Fix flaky TestAutoUpdateAgentShouldUpdate.

The issue was using the same clock for 2 different purposes (maintenance window logic and FnCache). Advancing the clock to invalidate the cache potentially put us outside of the maintenance window and failed the test.

@github-actions github-actions bot requested a review from tcsc December 6, 2024 16:00
@hugoShaka hugoShaka added flaky tests no-changelog Indicates that a PR does not require a changelog entry and removed size/sm labels Dec 6, 2024
@hugoShaka hugoShaka enabled auto-merge December 6, 2024 16:23
@hugoShaka hugoShaka added this pull request to the merge queue Dec 6, 2024
Merged via the queue into master with commit 3e3e464 Dec 6, 2024
40 checks passed
@hugoShaka hugoShaka deleted the hugo/fix-flaky-autoupdate-test branch December 6, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky tests no-changelog Indicates that a PR does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants