Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uri flag for s3 path style addressing configuration #49835

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

EdwardDowling
Copy link
Contributor

@EdwardDowling EdwardDowling commented Dec 5, 2024

Add ability to disable path-style S3 access for third-party endpoints.

part of: #48451
Fixes https://github.com/gravitational/customer-sensitive-requests/issues/346

changelog: Add ability to disable path-style S3 access for third-party endpoints.

@EdwardDowling EdwardDowling marked this pull request as ready for review December 11, 2024 17:34
@github-actions github-actions bot requested review from hugoShaka and tcsc December 11, 2024 17:34
@github-actions github-actions bot added audit-log Issues related to Teleports Audit Log size/sm labels Dec 11, 2024
@programmerq
Copy link
Contributor

This change looks good to me, but should probably have the storage backend doc reflect the change: https://github.com/gravitational/teleport/blob/master/docs/pages/reference/backends.mdx#s3-session-recordings

I think we'd only need to add this bullet point underneath the endpoint description.

  • use_s3_path_style - Whether to use path-style instead of virtual-host-style URLs for the bucket. Only applies when a custom endpoint is set. Defaults to true when unset. If used without a custom endpoint set, this option has no effect.

I'm happy to add this doc commit to the branch for this PR if it's helpful.

@EdwardDowling
Copy link
Contributor Author

This change looks good to me, but should probably have the storage backend doc reflect the change: https://github.com/gravitational/teleport/blob/master/docs/pages/reference/backends.mdx#s3-session-recordings

I think we'd only need to add this bullet point underneath the endpoint description.

* `use_s3_path_style` - Whether to use path-style instead of virtual-host-style URLs for the bucket. Only applies when a custom `endpoint` is set. Defaults to `true` when unset. If used without a custom `endpoint` set, this option has no effect.

I'm happy to add this doc commit to the branch for this PR if it's helpful.

Added it in there

Copy link

github-actions bot commented Jan 2, 2025

Amplify deployment status

Branch Commit Job ID Status Preview Updated (UTC)
edwarddowling/path-style HEAD 1 ✅SUCCEED edwarddowling-path-style 2025-01-02 16:23:38

@EdwardDowling
Copy link
Contributor Author

@hugoShaka @tcsc Can you take a look at this when you get a chance

@hugoShaka
Copy link
Contributor

Can we do a real-world test against an s3 backend not supporting path-style adressing and see if we can make teleport work? Or maybe send a dev build to the affected customer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants