Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v17] Move tooltips to the design package #49823

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

bl-nero
Copy link
Contributor

@bl-nero bl-nero commented Dec 5, 2024

Backport #49544 to branch/v17

Manual resolution required: a couple of touched files didn't exist in v17, one had a conflict in the imports.

  • web/packages/shared/components/Controls/MultiselectMenu.tsx (deleted)
  • web/packages/shared/components/Controls/SortMenu.tsx (deleted)
  • web/packages/shared/components/Controls/ViewModeSwitch.tsx (deleted)
  • web/packages/shared/components/UnifiedResources/FilterPanel.tsx (merged)
  • web/packages/teleport/src/Integrations/status/AwsOidc/AwsOidcHeader.tsx (deleted)

* Validation

Adds a model-level validation capability to our validation library.

* Move tooltips to the design package

They will be later required in the SlideTabs component

* Review

* Also, rename the tooltip directory

* Also, rename the tooltip component

* review

* Never return undefined from useValidation()
@bl-nero bl-nero added the no-changelog Indicates that a PR does not require a changelog entry label Dec 5, 2024
@bl-nero bl-nero marked this pull request as ready for review December 5, 2024 14:18
@github-actions github-actions bot requested review from avatus and gzdunek December 5, 2024 14:18
@bl-nero
Copy link
Contributor Author

bl-nero commented Dec 6, 2024

Verified existing tooltips on the unified resources page. Merging.

@bl-nero bl-nero added this pull request to the merge queue Dec 6, 2024
Merged via the queue into branch/v17 with commit 7a38323 Dec 6, 2024
42 checks passed
@bl-nero bl-nero deleted the bl-nero/backport-49544-branch/v17 branch December 6, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants