Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiscoveryConfigStatus: summary for AWS EC2 instances found #45637

Merged
merged 2 commits into from
Aug 28, 2024
Merged

DiscoveryConfigStatus: summary for AWS EC2 instances found #45637

merged 2 commits into from
Aug 28, 2024

Conversation

marcoandredinis
Copy link
Contributor

@marcoandredinis marcoandredinis commented Aug 20, 2024 •
edited
Loading

This PR adds the summary for AWS EC2 instances found for a given DiscoveryConfig.
This is going to be part of the AWS OIDC Integration dashboard.

Demo:
$ tctl get discovery_config/dc001 | yq .status

discovered_resources: 3
integration_discovered_resources:
  teleportdev:
    aws_ec2:
      enrolled: 1
      failed: 2
      found: 3
last_sync_time: "2024-08-27T10:09:09.912702Z"
state: DISCOVERY_CONFIG_STATE_SYNCING

Context: #41909

@marcoandredinis marcoandredinis added discover Issues related to Teleport Discover no-changelog Indicates that a PR does not require a changelog entry backport/branch/v16 labels Aug 20, 2024
@marcoandredinis marcoandredinis mentioned this pull request Aug 20, 2024
Open
@marcoandredinis marcoandredinis force-pushed the marco/discoveryconfigstatus_aws_counters_proto branch from 630f4a4 to fb7668a Compare August 21, 2024 10:37
@marcoandredinis marcoandredinis force-pushed the marco/discoveryconfigstatus_aws_counters branch from 218bce6 to a3dca70 Compare August 21, 2024 10:37
@marcoandredinis marcoandredinis force-pushed the marco/discoveryconfigstatus_aws_counters_proto branch from fb7668a to 2905c17 Compare August 23, 2024 09:24
@marcoandredinis marcoandredinis force-pushed the marco/discoveryconfigstatus_aws_counters branch from a3dca70 to 9b77367 Compare August 23, 2024 09:31
@marcoandredinis marcoandredinis marked this pull request as ready for review August 23, 2024 10:05
@marcoandredinis marcoandredinis force-pushed the marco/discoveryconfigstatus_aws_counters_proto branch from 2905c17 to 48618e2 Compare August 27, 2024 08:52
@marcoandredinis marcoandredinis force-pushed the marco/discoveryconfigstatus_aws_counters branch from 9b77367 to f02c54b Compare August 27, 2024 09:09
@marcoandredinis marcoandredinis force-pushed the marco/discoveryconfigstatus_aws_counters_proto branch from 48618e2 to 4c93489 Compare August 27, 2024 09:51
@marcoandredinis marcoandredinis force-pushed the marco/discoveryconfigstatus_aws_counters branch from f02c54b to c8f25c1 Compare August 27, 2024 09:58
@marcoandredinis marcoandredinis force-pushed the marco/discoveryconfigstatus_aws_counters_proto branch from 4c93489 to 0495278 Compare August 27, 2024 09:59
@marcoandredinis marcoandredinis force-pushed the marco/discoveryconfigstatus_aws_counters branch 2 times, most recently from 634efd5 to e39a89c Compare August 27, 2024 10:21
@marcoandredinis marcoandredinis mentioned this pull request Aug 27, 2024
Closed
Base automatically changed from marco/discoveryconfigstatus_aws_counters_proto to master August 27, 2024 13:39
@marcoandredinis
DiscoveryConfigStatus: summary for AWS EC2 instances found
725781a 
This PR adds the summary for AWS EC2 instances found for a given
DiscoveryConfig.
This is going to be part of the AWS OIDC Integration dashboard.
@marcoandredinis
use a map to index on the integration name
d5722e9
@marcoandredinis marcoandredinis force-pushed the marco/discoveryconfigstatus_aws_counters branch from e39a89c to d5722e9 Compare August 27, 2024 15:29
@marcoandredinis marcoandredinis added this pull request to the merge queue Aug 28, 2024
Merged via the queue into master with commit 629f0bc Aug 28, 2024
40 checks passed
@marcoandredinis marcoandredinis deleted the marco/discoveryconfigstatus_aws_counters branch August 28, 2024 07:51
@public-teleport-github-review-bot
Copy link

@marcoandredinis See the table below for backport results.

Branch Result
branch/v16 Create PR

@marcoandredinis marcoandredinis mentioned this pull request Aug 28, 2024
Merged
@programmerq programmerq mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joerger Joerger Joerger approved these changes

@probakowski probakowski probakowski approved these changes

Assignees
No one assigned
Labels
backport/branch/v16 discover Issues related to Teleport Discover discovery no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcoandredinis @probakowski @Joerger