Add conditional update methods for AccessList and AccessListMembers
#40036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds two new methods for conditinally update an AccessList and AccessListMember resources to avoid overriding changed resources. This is a preparation for a ineligible status reconciler. Signed-off-by: Tiago Silva <[email protected]>
tigrato
added
backport/branch/v14
no-changelog
rosstimothy
reviewed
Mar 29, 2024
Co-authored-by: rosstimothy <[email protected]>
rosstimothy
approved these changes
Mar 29, 2024
jakule
reviewed
Apr 1, 2024
| @@ -33,6 +33,8 @@ service AccessListService { | |||
| rpc GetAccessList(GetAccessListRequest) returns (AccessList); | |||
| // UpsertAccessList creates or updates an access list resource. | |||
| rpc UpsertAccessList(UpsertAccessListRequest) returns (AccessList); | |||
| // UpdateAccessList updates an access list resource. | |||
| rpc UpdateAccessList(UpdateAccessListRequest) returns (AccessList); | |||
There was a problem hiding this comment.
What is the difference between update and upsert? Those two methods sound confusing when you want to modify an access list.
There was a problem hiding this comment.
Upsert creates or unconditionally updates the access list - i,e. it doesn't care about revision. It will just replace whatever is in backend.
Update cares about revision and forces the revision to match before doing the update. If the revision doesn't match, it returns an error trace.CompareFailed
There was a problem hiding this comment.
Update and Upsert are pretty standard RPCs for our resources. See RFD 153 for the semantics and expected behaviors.
| @@ -184,6 +184,44 @@ func (a *AccessListService) UpsertAccessList(ctx context.Context, accessList *ac | |||
| return upserted, nil | |||
| } | |||
|
|
|||
| // UpdateAccessList updates an access list resource. | |||
| func (a *AccessListService) UpdateAccessList(ctx context.Context, accessList *accesslist.AccessList) (*accesslist.AccessList, error) { | |||
There was a problem hiding this comment.
The body of this function is almost the same as UpsertAccessList. Creating a common implementation for both will make the maintenance simpler.
tigrato
force-pushed
the
tigrato/access-list-boilerplate
branch
from
854509c to
5cc5dfb
Compare
jakule
approved these changes
Apr 2, 2024
tigrato
added a commit
that referenced
this pull request
Apr 8, 2024
…s` (#40036) * Add conditional update methods for `AccessList` and `AccessListMembers` This PR adds two new methods for conditinally update an AccessList and AccessListMember resources to avoid overriding changed resources. This is a preparation for a ineligible status reconciler. Signed-off-by: Tiago Silva <[email protected]> * Update lib/services/simple/access_list.go Co-authored-by: rosstimothy <[email protected]> * handle review comments and drop copy methods * simplify code --------- Signed-off-by: Tiago Silva <[email protected]> Co-authored-by: rosstimothy <[email protected]>
This was referenced Apr 8, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
…s` (#40036) (#40317) * Add conditional update methods for `AccessList` and `AccessListMembers` This PR adds two new methods for conditinally update an AccessList and AccessListMember resources to avoid overriding changed resources. This is a preparation for a ineligible status reconciler. * Update lib/services/simple/access_list.go * handle review comments and drop copy methods * simplify code --------- Signed-off-by: Tiago Silva <[email protected]> Co-authored-by: rosstimothy <[email protected]>
tigrato
added a commit
that referenced
this pull request
Apr 9, 2024
…s` (#40036) * Add conditional update methods for `AccessList` and `AccessListMembers` This PR adds two new methods for conditinally update an AccessList and AccessListMember resources to avoid overriding changed resources. This is a preparation for a ineligible status reconciler. Signed-off-by: Tiago Silva <[email protected]> * Update lib/services/simple/access_list.go Co-authored-by: rosstimothy <[email protected]> * handle review comments and drop copy methods * simplify code --------- Signed-off-by: Tiago Silva <[email protected]> Co-authored-by: rosstimothy <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
…s` (#40036) (#40318) * Add conditional update methods for `AccessList` and `AccessListMembers` This PR adds two new methods for conditinally update an AccessList and AccessListMember resources to avoid overriding changed resources. This is a preparation for a ineligible status reconciler. * Update lib/services/simple/access_list.go * handle review comments and drop copy methods * simplify code --------- Signed-off-by: Tiago Silva <[email protected]> Co-authored-by: rosstimothy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new methods for conditionally update an
AccessListandAccessListMemberresources to avoid overriding changed resources.This is a preparation for a ineligible status reconciler.