This repository has been archived by the owner on Jan 8, 2025. It is now read-only.
Fix bug in rehype-hljs-var #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, hljs generates text nodes that are direct descendents of a `code` element, without being the children of a `span`. rehype-hljs-var expects all text nodes to be the sole children of an element node. This change edits rehype-hljs-var to accommodate text nodes. It also refactors the plugin to clean up the logic for splitting text nodes with Var component placeholders.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
avatus
reviewed
Nov 18, 2024
| return placeholder; | ||
| } | ||
| ); | ||
| return [CONTINUE]; |
There was a problem hiding this comment.
what a weird pattern to return a const like that in an array lol, never seen anyhting like it.
There was a problem hiding this comment.
It's a tuple to control AST traversal: https://www.npmjs.com/package/unist-util-visit#visittree-test-visitor-reverse
Yeah, pretty odd!
avatus
approved these changes
Nov 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, hljs generates text nodes that are direct descendents of a
codeelement, without being the children of aspan. rehype-hljs-var expects all text nodes to be the sole children of an element node.This change edits rehype-hljs-var to accommodate text nodes. It also refactors the plugin to clean up the logic for splitting text nodes with Var component placeholders.