Support new sudokuwiki.org string definition #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I hope to get a chance to review this in a week or so. |
|
Friendly bump on this, in case you’ve had a chance to take a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #56
Modify the 'allDigits' string to use the new definition, which encodes candidate information.
Currently, this only uses the 'innerPencil' markings, as these are what are populated by default when using the auto-calculate candidates function. Further, this ignores the hide pencil markings setting, but am happy to change this to only account for candidates when pencil markings are being shown if desired.
Tests cover empty grids with no candidate information; auto-calculated candidates; a mixture of candidates, givens, and solved clues; a mixture of candidates, givens, solved clues and cells with no candidate information.