g:form csrf protection adjustments #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e filterChain registration additions. Also ignore situations where FilterChainProxy exists in classpath, but is not being used.
bkoehm
approved these changes
Nov 22, 2024
| @@ -85,7 +90,7 @@ class FormTagLib implements ApplicationContextAware, InitializingBean, TagLibrar | |||
| springSecurityCsrfTokenClass = | |||
| Class.forName("org.springframework.security.web.csrf.CsrfToken") | |||
| } | |||
| } catch (ClassNotFoundException ignore) {} | |||
| } catch (ClassNotFoundException | BeansException ignore) {} | |||
There was a problem hiding this comment.
This works. My only question is you want to ignore all bean exceptions rather than just NoSuchBeanDefinitionException?
There was a problem hiding this comment.
@bkoehm because there could be a situation where you have no bean and also a situation where you have 2 beans the you should only have 1. this catches both of them. There could very well be a situation where somebody mistakenly has a duplicate registration. No need to fail because of that and both of those exception types extend BeansException.
jdaugherty
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move configureCsrf into method that can also be invoked later for late filterChain registration additions.
Iignore situations where FilterChainProxy exists in classpath, but is not being used.