-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add filter affected services internal endpoint #5415
Conversation
e84e0e5
to
507d9ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
More out of curiosity, was does "affected" mean in this context? It just means Alert Groups that have a service_name
label, right?
Or is it more robust than that and has to do w/ service dependencies? (ie. if Service A depends on Service B and Service B is "degraded", return me Service A).
Also, isn't filter_affected_services
mostly just doing label key:value filtering? (if so, don't we have an existing endpoint for this?)
Original implementation would find out upstream service dependencies for Makes sense? Happy to rename as needed. |
ahh okay, makes sense 🙂 thanks! |
Related to https://github.com/grafana/oncall-private/issues/2977
e.g.
GET /api/plugins/grafana-oncall-app/resources/alertgroups/filter_affected_services?service=service-a&service=service-b