fix: Add rolling users validation for oncall shift API #5050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravishankar15
force-pushed
the
rolling-users-validation
branch
from
3f6219b to
a74bb03
Compare
joeyorlando
approved these changes
Sep 20, 2024
joeyorlando
added
pr:no public docs
ravishankar15
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ravishankar15
had a problem deploying
to
github-pages
GitHub Actions
Failure
ravishankar15
temporarily deployed
to
github-pages
GitHub Actions
Inactive
matiasb
reviewed
Sep 20, 2024
| if not self.db_verification: | ||
| return users | ||
|
|
||
| for d in data: |
There was a problem hiding this comment.
Would this check be equivalent to do something like
len(set(data)) == users.count()
(ie. make sure we have a user per provided ppk)? I guess you could do a set difference to get the missing users too?
There was a problem hiding this comment.
I have Made the changes accordingly
| @@ -29,7 +29,7 @@ class OnCallShiftSerializer(EagerLoadingMixin, serializers.ModelSerializer): | |||
| allow_null=True, | |||
| required=False, | |||
| child=UsersFilteredByOrganizationField( | |||
| queryset=User.objects, required=False, allow_null=True | |||
| queryset=User.objects, db_verification=True, required=False, allow_null=True | |||
There was a problem hiding this comment.
I would suggest a different name for the param, based on my understanding of the check (see also the comment below), eg. require_all_exist?
ravishankar15
had a problem deploying
to
github-pages
GitHub Actions
Failure
ravishankar15
had a problem deploying
to
github-pages
GitHub Actions
Failure
ravishankar15
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ravishankar15
had a problem deploying
to
github-pages
GitHub Actions
Failure
ravishankar15
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ravishankar15
had a problem deploying
to
github-pages
GitHub Actions
Failure
ravishankar15
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds validation for rolling users param in the shift api
Which issue(s) this PR closes
Closes 5041
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.