fix e2e tests #3950
Merged
fix e2e tests #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
added
pr:no changelog
pr:no public docs
joeyorlando
commented
Feb 22, 2024
| @@ -13,7 +13,7 @@ export const createOnCallSchedule = async (page: Page, scheduleName: string, use | |||
| (await page.waitForSelector('button >> text=Create >> nth=0')).click(); | |||
|
|
|||
| // fill in the name input | |||
| await fillInInput(page, 'div[class*="ScheduleForm"] input[name="name"]', scheduleName); | |||
There was a problem hiding this comment.
my guess is that the css class names were changed in #3837 (I'm guessing because of the @emotion/css dependency being added?)
nevertheless, selecting locators based on css class names is fragile and we should prefer data-testid whenever possible.
There was a problem hiding this comment.
Completely agree, selecting by aria roles, text and/or testids is recommended
…root when token is invalid
brojd
approved these changes
Feb 22, 2024
brojd
added a commit
that referenced
this pull request
Sep 18, 2024
# Which issue(s) this PR fixes Fix failing e2e tests on `dev` ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) --------- Co-authored-by: Dominik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Fix failing e2e tests on
devChecklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)