Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-stack support for mobile app #3500

Merged
merged 19 commits into from
Dec 13, 2023
Merged

Conversation

Ferril
Copy link
Member

@Ferril Ferril commented Dec 5, 2023

What this PR does

Allow creating multiple mobile devices with same registration_id for different users (multi-stack support)

Which issue(s) this PR fixes

#3452

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@Ferril Ferril added the pr:no public docs Added to a PR that does not require public documentation updates label Dec 6, 2023
@Ferril Ferril marked this pull request as ready for review December 6, 2023 12:04
@Ferril Ferril requested a review from a team December 6, 2023 12:04
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some very minor nit comments 👍

CHANGELOG.md Outdated Show resolved Hide resolved
engine/apps/mobile_app/views.py Outdated Show resolved Hide resolved
engine/apps/mobile_app/serializers.py Outdated Show resolved Hide resolved
engine/apps/mobile_app/serializers.py Outdated Show resolved Hide resolved
@Ferril Ferril added this pull request to the merge queue Dec 13, 2023
Merged via the queue into dev with commit 088414c Dec 13, 2023
21 checks passed
@Ferril Ferril deleted the mobile-app-multistack-support branch December 13, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants