Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RBAC authz issue for Slack Alert Group actions #3213

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

joeyorlando
Copy link
Contributor

@joeyorlando joeyorlando commented Oct 30, 2023

Was able to reproduce locally with OnCall RBAC enabled and as a user with Viewer role:
Screenshot 2023-10-30 at 09 30 52

Fixed with the changes introduced in this PR:
Screenshot 2023-10-30 at 09 30 16
Screenshot 2023-10-30 at 09 30 11

Which issue(s) this PR fixes

Closes #3212

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@joeyorlando joeyorlando added pr:no changelog pr:no public docs Added to a PR that does not require public documentation updates labels Oct 30, 2023
@joeyorlando joeyorlando self-assigned this Oct 30, 2023
@joeyorlando joeyorlando requested a review from a team October 30, 2023 13:32
@joeyorlando joeyorlando merged commit 6a78ee6 into dev Oct 30, 2023
19 of 20 checks passed
@joeyorlando joeyorlando deleted the jorlando/slack-authz-rbac-patch branch October 30, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack authz error when trying to ack Alert Group as Viewer/OnCaller user (RBAC)
2 participants