Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack authz error when trying to ack Alert Group as Viewer/OnCaller user (RBAC) #3212

Closed
joeyorlando opened this issue Oct 30, 2023 · 0 comments · Fixed by #3213
Closed

Slack authz error when trying to ack Alert Group as Viewer/OnCaller user (RBAC) #3212

joeyorlando opened this issue Oct 30, 2023 · 0 comments · Fixed by #3213
Assignees
@joeyorlando
Labels
bug Something isn't working part:chatops

Comments

@joeyorlando
Copy link
Contributor

joeyorlando commented Oct 30, 2023 •
edited
Loading

What went wrong?

What happened:

  • I have RBAC for OnCall enabled. I have a user with the roles of Viewer + OnCaller. When I try to ack an Alert Group message in Slack I get the following error:
Screenshot 2023-10-30 at 09 30 52

What did you expect to happen:

  • I would expect the ack to work properly and actually ack the Alert Group

How do we reproduce it?

See steps above under "What went wrong?"

Grafana OnCall Version

v10.0.2

Product Area

Chatops

Grafana OnCall Platform?

Docker

User's Browser?

N/A

Anything else to add?

No response
@joeyorlando joeyorlando added the bug Something isn't working label Oct 30, 2023
@joeyorlando joeyorlando self-assigned this Oct 30, 2023
@joeyorlando joeyorlando changed the title Slack HTTP 404 when trying to ack Alert Group as Viewer/OnCaller user (RBAC) Slack authz error when trying to ack Alert Group as Viewer/OnCaller user (RBAC) Oct 30, 2023
@joeyorlando joeyorlando mentioned this issue Oct 30, 2023
Merged
3 tasks
joeyorlando added a commit that referenced this issue Oct 30, 2023
@joeyorlando
fix RBAC authz issue for Slack Alert Group actions (#3213)
6a78ee6 
Was able to reproduce locally with OnCall RBAC enabled and as a user
with Viewer role:
<img width="701" alt="Screenshot 2023-10-30 at 09 30 52"
src="https://github.com/grafana/oncall/assets/9406895/0050c2b1-2765-4aba-a73e-985f364691ad">

Fixed with the changes introduced in this PR:
<img width="963" alt="Screenshot 2023-10-30 at 09 30 16"
src="https://github.com/grafana/oncall/assets/9406895/02b62f39-01e5-4a13-baaf-db30181eb16a">
<img width="967" alt="Screenshot 2023-10-30 at 09 30 11"
src="https://github.com/grafana/oncall/assets/9406895/c606f6db-8e99-4df4-a3e9-5c9da8feb051">



## Which issue(s) this PR fixes

Closes #3212 

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeyorlando joeyorlando

Labels
bug Something isn't working part:chatops
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix RBAC authz issue for Slack Alert Group actions grafana/oncall
1 participant
@joeyorlando