MQE: Add support for delta function #9795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
reviewed
Nov 10, 2024
lamida
force-pushed
the
lamida/mqe-delta-function
branch
3 times, most recently
from
b4c6a45 to
840c870
Compare
lamida
force-pushed
the
lamida/mqe-delta-function
branch
from
840c870 to
0dfa2c1
Compare
|
The CHANGELOG has just been cut to prepare for the next release. Please rebase |
lamida
force-pushed
the
lamida/mqe-delta-function
branch
from
0dfa2c1 to
3cedd49
Compare
jhesketh
reviewed
Dec 16, 2024
There was a problem hiding this comment.
I agree with the separation of rate from delta. However, I also think this is how it's done upstream so I'm okay either way.
We should add some more tests to our tests. Specifically around native histograms and mixed data types. eg: what is the delta when the first and last sample are different types. What about having a NH in the middle of a vector of floats etc..
lamida
force-pushed
the
lamida/mqe-delta-function
branch
2 times, most recently
from
02a5e6d to
daf0654
Compare
charleskorn
reviewed
Jan 6, 2025
4 tasks
lamida
force-pushed
the
lamida/mqe-delta-function
branch
from
9d21d80 to
a4b03d5
Compare
charleskorn
reviewed
Jan 9, 2025
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
* Extract delta from rate function Signed-off-by: Jon Kartago Lamida <[email protected]> * Update pkg/streamingpromql/operators/functions/rate_increase.go Co-authored-by: Charles Korn <[email protected]> * Update pkg/streamingpromql/operators/functions/rate_increase.go Co-authored-by: Charles Korn <[email protected]> * Update pkg/streamingpromql/operators/functions/rate_increase.go Co-authored-by: Charles Korn <[email protected]> * Update pkg/streamingpromql/operators/functions/rate_increase.go Co-authored-by: Charles Korn <[email protected]> * Tidy up after applying PR suggestion Signed-off-by: Jon Kartago Lamida <[email protected]> * Remove unnecessary head subslice Signed-off-by: Jon Kartago Lamida <[email protected]> * Remove wrong placed annotation Signed-off-by: Jon Kartago Lamida <[email protected]> * Remove extra copySchema Signed-off-by: Jon Kartago Lamida <[email protected]> * Simplify native histogram sub schema Signed-off-by: Jon Kartago Lamida <[email protected]> * Remove TODO Signed-off-by: Jon Kartago Lamida <[email protected]> * The lastPoint should be last index of the head Signed-off-by: Jon Kartago Lamida <[email protected]> * Add delta counterResetHint test Signed-off-by: Jon Kartago Lamida <[email protected]> --------- Signed-off-by: Jon Kartago Lamida <[email protected]> Co-authored-by: Charles Korn <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
lamida
force-pushed
the
lamida/mqe-delta-function
branch
from
19045f9 to
27fce29
Compare
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
charleskorn
reviewed
Jan 10, 2025
| # {path="/bar"} -200 | ||
| eval instant at 20m delta(http_requests[20m]) | ||
| {path="/foo"} 200 | ||
| {path="/bar"} -200 | ||
|
|
||
| # Unsupported by streaming engine. |
There was a problem hiding this comment.
Could you please enable the new delta-related tests below?
tools/check-for-disabled-but-supported-mqe-test-cases will help identify any test cases that might be able to be enabled.
There was a problem hiding this comment.
Oh missed that. Updated in e72c504
Co-authored-by: Charles Korn <[email protected]>
Co-authored-by: Charles Korn <[email protected]>
Co-authored-by: Charles Korn <[email protected]>
Co-authored-by: Charles Korn <[email protected]>
Co-authored-by: Charles Korn <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Signed-off-by: Jon Kartago Lamida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.