Rule Concurrency: Fix debug log #10409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienduchesne
force-pushed
the
julienduchesne/rule-concurrency-fix-log
branch
from
034ab29 to
6476312
Compare
The log added here: https://github.com/grafana/mimir/pull/10400/files#diff-3e8efecf11fa9185935eea3d3c9c7993f99422353a391190657877e902875a37R254 doesn't work for all loggers When I tested it in dev, I got some of these errors: ``` ts=2025-01-10T17:26:37.207249729Z caller=rule_concurrency.go:254 level=debug component=concurrency-controller tenant=17065 group=mimir_querier_api msg="Batched rules into concurrent blocks" batches="unsupported value type" ``` I added a new `fmt.Stringer` type for the slice because I don't want the debug log to negatively affect performance (the added benchmark showed that stringing had a 25% performance hit)
julienduchesne
force-pushed
the
julienduchesne/rule-concurrency-fix-log
branch
from
6476312 to
cb9b520
Compare
dimitarvdimitrov
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log added here: https://github.com/grafana/mimir/pull/10400/files#diff-3e8efecf11fa9185935eea3d3c9c7993f99422353a391190657877e902875a37R254 doesn't work for all loggers
When I tested it in dev, I got some of these errors:
I added a new
fmt.Stringertype for the slice because I don't want the debug log to negatively affect performance (the added benchmark showed that stringing had a 25% performance hit)