Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruler: increase retries backoff limit to 1m #10403

Merged

Conversation

dimitarvdimitrov
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov commented Jan 10, 2025

What this PR does

the previous limit of 2s is too small and doesn't end up spreading out retries for long enough

follow-up of #10375

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

the previous limit of 2s is too small and doesn't end up spreading out retries for long enough

Signed-off-by: Dimitar Dimitrov <[email protected]>
@dimitarvdimitrov dimitarvdimitrov requested review from a team as code owners January 10, 2025 14:02
Signed-off-by: Dimitar Dimitrov <[email protected]>
Copy link
Contributor

@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@dimitarvdimitrov dimitarvdimitrov merged commit 8bedb97 into main Jan 10, 2025
34 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the dimitar/ruler/increase-max-backoff-duration-to-1m branch January 10, 2025 14:35
@grafanabot
Copy link
Contributor

The backport to r316 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-10403-to-r316 origin/r316
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 8bedb97dd18aa7b12863caa4c413b52c81cbc8ec
# Push it to GitHub
git push --set-upstream origin backport-10403-to-r316
git switch main
# Remove the local backport branch
git branch -D backport-10403-to-r316

Then, create a pull request where the base branch is r316 and the compare/head branch is backport-10403-to-r316.

@grafanabot
Copy link
Contributor

The backport to r321 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-10403-to-r321 origin/r321
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 8bedb97dd18aa7b12863caa4c413b52c81cbc8ec
# Push it to GitHub
git push --set-upstream origin backport-10403-to-r321
git switch main
# Remove the local backport branch
git branch -D backport-10403-to-r321

Then, create a pull request where the base branch is r321 and the compare/head branch is backport-10403-to-r321.

@grafanabot
Copy link
Contributor

The backport to r320 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-10403-to-r320 origin/r320
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 8bedb97dd18aa7b12863caa4c413b52c81cbc8ec
# Push it to GitHub
git push --set-upstream origin backport-10403-to-r320
git switch main
# Remove the local backport branch
git branch -D backport-10403-to-r320

Then, create a pull request where the base branch is r320 and the compare/head branch is backport-10403-to-r320.

dimitarvdimitrov added a commit that referenced this pull request Jan 10, 2025
* ruler: increase retries backoff limit to 1m

the previous limit of 2s is too small and doesn't end up spreading out retries for long enough

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Update CHANGELOG.md entry

Signed-off-by: Dimitar Dimitrov <[email protected]>

---------

Signed-off-by: Dimitar Dimitrov <[email protected]>
(cherry picked from commit 8bedb97)
dimitarvdimitrov added a commit that referenced this pull request Jan 10, 2025
* ruler: increase retries backoff limit to 1m

the previous limit of 2s is too small and doesn't end up spreading out retries for long enough

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Update CHANGELOG.md entry

Signed-off-by: Dimitar Dimitrov <[email protected]>

---------

Signed-off-by: Dimitar Dimitrov <[email protected]>
(cherry picked from commit 8bedb97)
dimitarvdimitrov added a commit that referenced this pull request Jan 10, 2025
* ruler: increase retries backoff limit to 1m

the previous limit of 2s is too small and doesn't end up spreading out retries for long enough

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Update CHANGELOG.md entry

Signed-off-by: Dimitar Dimitrov <[email protected]>

---------

Signed-off-by: Dimitar Dimitrov <[email protected]>
(cherry picked from commit 8bedb97)
dimitarvdimitrov added a commit that referenced this pull request Jan 10, 2025
* ruler: increase retries backoff limit to 1m

the previous limit of 2s is too small and doesn't end up spreading out retries for long enough

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Update CHANGELOG.md entry

Signed-off-by: Dimitar Dimitrov <[email protected]>

---------

Signed-off-by: Dimitar Dimitrov <[email protected]>
(cherry picked from commit 8bedb97)

Co-authored-by: Dimitar Dimitrov <[email protected]>
dimitarvdimitrov added a commit that referenced this pull request Jan 10, 2025
* ruler: increase retries backoff limit to 1m

the previous limit of 2s is too small and doesn't end up spreading out retries for long enough

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Update CHANGELOG.md entry

Signed-off-by: Dimitar Dimitrov <[email protected]>

---------

Signed-off-by: Dimitar Dimitrov <[email protected]>
(cherry picked from commit 8bedb97)
dimitarvdimitrov added a commit that referenced this pull request Jan 10, 2025
* ruler: increase retries backoff limit to 1m

the previous limit of 2s is too small and doesn't end up spreading out retries for long enough

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Update CHANGELOG.md entry

Signed-off-by: Dimitar Dimitrov <[email protected]>

---------

Signed-off-by: Dimitar Dimitrov <[email protected]>
(cherry picked from commit 8bedb97)
dimitarvdimitrov added a commit that referenced this pull request Jan 10, 2025
* ruler: increase retries backoff limit to 1m

the previous limit of 2s is too small and doesn't end up spreading out retries for long enough

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Update CHANGELOG.md entry

Signed-off-by: Dimitar Dimitrov <[email protected]>

---------

Signed-off-by: Dimitar Dimitrov <[email protected]>
(cherry picked from commit 8bedb97)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants