Update to latest mimir-prometheus #10400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also implement new rule concurrency interface from prometheus/prometheus#15681
Same fix as prometheus/prometheus#15711 and similar to what was done during the last sync: #10383
julienduchesne
force-pushed
the
julienduchesne/concurrency-batches
branch
from
8d5b863 to
6838f78
Compare
charleskorn
reviewed
Jan 10, 2025
julienduchesne
requested review from
stevesg,
grafanabot and
a team
as code owners
jhesketh
approved these changes
Jan 10, 2025
A nil slice will run rules sequentially
julienduchesne
force-pushed
the
julienduchesne/concurrency-batches
branch
from
dabab47 to
014d6d1
Compare
gotjosh
reviewed
Jan 10, 2025
gotjosh
reviewed
Jan 10, 2025
gotjosh
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RuleConcurrencyController: AddSplitGroupIntoBatchesmethod prometheus/prometheus#15681Same fix as [BUGFIX] PromQL: Fix
<aggr_over_time>functions with histograms prometheus/prometheus#15711 and similar to what was done during the last sync: Bump to latest mimir-prometheus #10383