Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockbuilder): mark a job as complete only after stopping sync updates #15670

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

ashwanthgoli
Copy link
Contributor

What this PR does / why we need it:
Send completed job request only after stopping sync updates. Currently there is a race where a sync request could mark an already completed job as in-progress. This in-progress job would eventually expire and get re-enqueued resulting in duplicate work.

also removes unused and misleading CLI flag -block-scheduler.consumer-group

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@ashwanthgoli ashwanthgoli requested a review from a team as a code owner January 9, 2025 11:53
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jan 9, 2025
@ashwanthgoli ashwanthgoli changed the title Blockbuilder/improvements chore(blockbuilder): stop sync updates before calling SendCompleteJob Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

💻 Deploy preview deleted.

@ashwanthgoli ashwanthgoli changed the title chore(blockbuilder): stop sync updates before calling SendCompleteJob chore(blockbuilder): mark a job as complete only after stopping sync updates Jan 9, 2025
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashwanthgoli ashwanthgoli merged commit b5c627b into main Jan 9, 2025
62 checks passed
@ashwanthgoli ashwanthgoli deleted the blockbuilder/improvements branch January 9, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants