Fix error source for invalid or missing authentication token #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesoreyeram
reviewed
Dec 5, 2024
| } | ||
| err = zabbix.api.AuthenticateWithToken(ctx, token) | ||
| if err != nil { | ||
| zabbix.logger.Error("Zabbix authentication error", "error", err) | ||
| return err | ||
| return backend.DownstreamError(err) |
There was a problem hiding this comment.
nit. While you are here, can you also update the remaining auth errors in this file such as https://github.com/grafana/grafana-zabbix/pull/1927/files#diff-5208b24d9796d40dfcd17ea2b6bc1f0b592a8358db7416e02ace589ab32b90f2R147 otherwise we may end up in multiple patch releases.
There was a problem hiding this comment.
I missed that and that has more complex logic. So will need to address it better. Turning this to draft in the meantime.
yesoreyeram
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/grafana/data-sources/issues/251 and creates a patch release.
It makes following errors downstream: