Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setKioskMode() #53

Closed

Conversation

intermittentnrg
Copy link
Collaborator

Fixes Uncaught TypeError: document.querySelector(...) is null

Reproducible in standalone browser

Fixes Uncaught TypeError: document.querySelector(...) is null

Reproducible in standalone browser
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.58%. Comparing base (36b61a2) to head (cb11e58).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   89.58%   89.58%           
=======================================
  Files           3        3           
  Lines         192      192           
=======================================
  Hits          172      172           
  Misses         20       20           
Flag Coverage Δ
unittests 89.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@intermittentnrg
Copy link
Collaborator Author

Alternatively set query = "?kiosk" in core.py and remove grafana-studio.js setKioskMode()

I'd prefer this.

@amotl
Copy link
Contributor

amotl commented Jan 11, 2025

I don't have any objections about the alternative GH-54. What do you think, @maurerle?

@intermittentnrg
Copy link
Collaborator Author

I think we can close this PR in favor of #54 then.

@maurerle
Copy link
Collaborator

yes, that's not a proper fix anyway.

Checking if document.querySelector('[title="Enable kiosk mode"]') is null should be better

@maurerle maurerle closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants