refactor: better ergonomics on test macros

gp-pereira · Dec 9, 2024 · 514a968 · 514a968
1 parent 316c17f
commit 514a968
Show file tree

Hide file tree

Showing 29 changed files with 99 additions and 100 deletions.
diff --git a/test/refactor/alias/expand_aliases_test.exs b/test/refactor/alias/expand_aliases_test.exs
@@ -117,7 +117,7 @@ defmodule Refactorex.Refactor.Alias.ExpandAliasesTest do
   end
 
   test "ignores outside module" do
-    assert_not_refactored(
+    assert_ignored(
       ExpandAliases,
       """
       #          v
@@ -128,7 +128,7 @@ defmodule Refactorex.Refactor.Alias.ExpandAliasesTest do
   end
 
   test "ignores outside alias" do
-    assert_not_refactored(
+    assert_ignored(
       ExpandAliases,
       """
       defmodule Foo do

diff --git a/test/refactor/alias/extract_alias_test.exs b/test/refactor/alias/extract_alias_test.exs
@@ -114,7 +114,7 @@ defmodule Refactorex.Refactor.Alias.ExtractAliasTest do
   end
 
   test "ignores alias declaration" do
-    assert_not_refactored(
+    assert_ignored(
       ExtractAlias,
       """
       defmodule Foo do
@@ -127,7 +127,7 @@ defmodule Refactorex.Refactor.Alias.ExtractAliasTest do
   end
 
   test "ignores single alias" do
-    assert_not_refactored(
+    assert_ignored(
       ExtractAlias,
       """
       defmodule Foo do
@@ -142,7 +142,7 @@ defmodule Refactorex.Refactor.Alias.ExtractAliasTest do
   end
 
   test "ignores if there would be a name conflict" do
-    assert_not_refactored(
+    assert_ignored(
       ExtractAlias,
       """
       defmodule Foo do
@@ -159,7 +159,7 @@ defmodule Refactorex.Refactor.Alias.ExtractAliasTest do
   end
 
   test "ignores outside module" do
-    assert_not_refactored(
+    assert_ignored(
       ExtractAlias,
       """
       def foo() do

diff --git a/test/refactor/alias/inline_alias_test.exs b/test/refactor/alias/inline_alias_test.exs
@@ -188,7 +188,7 @@ defmodule Refactorex.Refactor.Alias.InlineAliasTest do
   end
 
   test "ignores alias declaration" do
-    assert_not_refactored(
+    assert_ignored(
       InlineAlias,
       """
       defmodule Foo do
@@ -205,7 +205,7 @@ defmodule Refactorex.Refactor.Alias.InlineAliasTest do
   end
 
   test "ignores aliases without same module declaration" do
-    assert_not_refactored(
+    assert_ignored(
       InlineAlias,
       """
       defmodule Foo do

diff --git a/test/refactor/alias/merge_aliases_test.exs b/test/refactor/alias/merge_aliases_test.exs
@@ -229,7 +229,7 @@ defmodule Refactorex.Refactor.Alias.MergeAliasesTest do
   end
 
   test "ignores single alias" do
-    assert_not_refactored(
+    assert_ignored(
       MergeAliases,
       """
       defmodule Foo do
@@ -242,7 +242,7 @@ defmodule Refactorex.Refactor.Alias.MergeAliasesTest do
   end
 
   test "ignores unmergeable aliases" do
-    assert_not_refactored(
+    assert_ignored(
       MergeAliases,
       """
       defmodule Foo do
@@ -256,7 +256,7 @@ defmodule Refactorex.Refactor.Alias.MergeAliasesTest do
   end
 
   test "ignores outside alias" do
-    assert_not_refactored(
+    assert_ignored(
       MergeAliases,
       """
       defmodule Foo do
@@ -271,7 +271,7 @@ defmodule Refactorex.Refactor.Alias.MergeAliasesTest do
   end
 
   test "ignores partially selected alias" do
-    assert_not_refactored(
+    assert_ignored(
       MergeAliases,
       """
       defmodule Foo do

diff --git a/test/refactor/alias/sort_nested_aliases_test.exs b/test/refactor/alias/sort_nested_aliases_test.exs
@@ -62,7 +62,7 @@ defmodule Refactorex.Refactor.Alias.SortNestedAliasesTest do
   end
 
   test "ignores alias without nesting" do
-    assert_not_refactored(
+    assert_ignored(
       SortNestedAliases,
       """
       #   v
@@ -72,7 +72,7 @@ defmodule Refactorex.Refactor.Alias.SortNestedAliasesTest do
   end
 
   test "ignores already sorted alias" do
-    assert_not_refactored(
+    assert_ignored(
       SortNestedAliases,
       """
       #   v

diff --git a/test/refactor/constant/extract_constant_test.exs b/test/refactor/constant/extract_constant_test.exs
@@ -162,7 +162,7 @@ defmodule Refactorex.Refactor.Constant.ExtractConstantTest do
   end
 
   test "ignores constants" do
-    assert_not_refactored(
+    assert_ignored(
       ExtractConstant,
       """
       defmodule Foo do
@@ -180,7 +180,7 @@ defmodule Refactorex.Refactor.Constant.ExtractConstantTest do
   end
 
   test "ignores anonymous function" do
-    assert_not_refactored(
+    assert_ignored(
       ExtractConstant,
       """
       defmodule Foo do
@@ -197,7 +197,7 @@ defmodule Refactorex.Refactor.Constant.ExtractConstantTest do
   end
 
   test "ignores selection ranges with variables" do
-    assert_not_refactored(
+    assert_ignored(
       ExtractConstant,
       """
       defmodule Foo do
@@ -212,7 +212,7 @@ defmodule Refactorex.Refactor.Constant.ExtractConstantTest do
   end
 
   test "ignores pipe function calls" do
-    assert_not_refactored(
+    assert_ignored(
       ExtractConstant,
       """
       defmodule Foo do
@@ -227,7 +227,7 @@ defmodule Refactorex.Refactor.Constant.ExtractConstantTest do
   end
 
   test "ignores selection ranges outside modules" do
-    assert_not_refactored(
+    assert_ignored(
       ExtractConstant,
       """
       #               v
@@ -238,7 +238,7 @@ defmodule Refactorex.Refactor.Constant.ExtractConstantTest do
   end
 
   test "ignores alias" do
-    assert_not_refactored(
+    assert_ignored(
       ExtractConstant,
       """
       defmodule Foo do

diff --git a/test/refactor/constant/inline_constant_test.exs b/test/refactor/constant/inline_constant_test.exs
@@ -56,7 +56,7 @@ defmodule Refactorex.Refactor.Constant.InlineConstantTest do
   end
 
   test "ignores the constant definition" do
-    assert_not_refactored(
+    assert_ignored(
       InlineConstant,
       """
       defmodule Foo do
@@ -73,7 +73,7 @@ defmodule Refactorex.Refactor.Constant.InlineConstantTest do
   end
 
   test "ignores constant without a previous definition" do
-    assert_not_refactored(
+    assert_ignored(
       InlineConstant,
       """
       defmodule Foo do

diff --git a/test/refactor/constant/rename_constant_test.exs b/test/refactor/constant/rename_constant_test.exs
@@ -108,7 +108,7 @@ defmodule Refactorex.Refactor.Constant.RenameConstantTest do
   end
 
   test "ignores variables" do
-    assert_not_refactored(
+    assert_ignored(
       RenameConstant,
       """
       defmodule Foo do

diff --git a/test/refactor/function/collapse_anonymous_function_test.exs b/test/refactor/function/collapse_anonymous_function_test.exs
@@ -45,7 +45,7 @@ defmodule Refactorex.Refactor.Function.CollapseAnonymousFunctionTest do
   end
 
   test "ignores anonymous function with pattern matching" do
-    assert_not_refactored(
+    assert_ignored(
       CollapseAnonymousFunction,
       """
       #                   v
@@ -56,7 +56,7 @@ defmodule Refactorex.Refactor.Function.CollapseAnonymousFunctionTest do
   end
 
   test "ignores anonymous function with multiples statements" do
-    assert_not_refactored(
+    assert_ignored(
       CollapseAnonymousFunction,
       """
       #                   v
@@ -70,7 +70,7 @@ defmodule Refactorex.Refactor.Function.CollapseAnonymousFunctionTest do
   end
 
   test "ignores anonymous function with multiples clauses" do
-    assert_not_refactored(
+    assert_ignored(
       CollapseAnonymousFunction,
       """
       #                   v
@@ -84,7 +84,7 @@ defmodule Refactorex.Refactor.Function.CollapseAnonymousFunctionTest do
   end
 
   test "ignores anonymous function with zero args" do
-    assert_not_refactored(
+    assert_ignored(
       CollapseAnonymousFunction,
       """
       def foo do
@@ -97,7 +97,7 @@ defmodule Refactorex.Refactor.Function.CollapseAnonymousFunctionTest do
   end
 
   test "ignores anonymous function with unused args" do
-    assert_not_refactored(
+    assert_ignored(
       CollapseAnonymousFunction,
       """
       def foo do

diff --git a/test/refactor/function/expand_anonymous_function_test.exs b/test/refactor/function/expand_anonymous_function_test.exs
@@ -70,7 +70,7 @@ defmodule Refactorex.Refactor.Function.ExpandAnonymousFunctionTest do
   end
 
   test "ignores capture variables" do
-    assert_not_refactored(
+    assert_ignored(
       ExpandAnonymousFunction,
       """
       def foo(modules) do

diff --git a/test/refactor/function/extract_anonymous_function_test.exs b/test/refactor/function/extract_anonymous_function_test.exs
@@ -450,7 +450,7 @@ defmodule Refactorex.Refactor.Function.ExtractAnonymousFunctionTest do
   end
 
   test "ignores anonymous function that is not inside a module" do
-    assert_not_refactored(
+    assert_ignored(
       ExtractAnonymousFunction,
       """
       def power_sum(numbers, power) do
@@ -463,7 +463,7 @@ defmodule Refactorex.Refactor.Function.ExtractAnonymousFunctionTest do
   end
 
   test "ignores anonymous function with zero arguments" do
-    assert_not_refactored(
+    assert_ignored(
       ExtractAnonymousFunction,
       """
       defmodule Middleware do
@@ -478,7 +478,7 @@ defmodule Refactorex.Refactor.Function.ExtractAnonymousFunctionTest do
   end
 
   test "ignores already extracted function" do
-    assert_not_refactored(
+    assert_ignored(
       ExtractAnonymousFunction,
       """
       defmodule Foo do

diff --git a/test/refactor/function/extract_function_test.exs b/test/refactor/function/extract_function_test.exs
@@ -194,7 +194,7 @@ defmodule Refactorex.Refactor.Function.ExtractFunctionTest do
   end
 
   test "ignore with clauses" do
-    assert_not_refactored(
+    assert_ignored(
       ExtractFunction,
       """
       defmodule Foo do
@@ -211,7 +211,7 @@ defmodule Refactorex.Refactor.Function.ExtractFunctionTest do
   end
 
   test "ignore module constants" do
-    assert_not_refactored(
+    assert_ignored(
       ExtractFunction,
       """
       defmodule Foo do
@@ -228,7 +228,7 @@ defmodule Refactorex.Refactor.Function.ExtractFunctionTest do
   end
 
   test "ignore anonymous functions" do
-    assert_not_refactored(
+    assert_ignored(
       ExtractFunction,
       """
       defmodule Foo do
@@ -245,7 +245,7 @@ defmodule Refactorex.Refactor.Function.ExtractFunctionTest do
   end
 
   test "ignore variable declaration functions" do
-    assert_not_refactored(
+    assert_ignored(
       ExtractFunction,
       """
       defmodule Foo do
@@ -262,7 +262,7 @@ defmodule Refactorex.Refactor.Function.ExtractFunctionTest do
   end
 
   test "ignores alias" do
-    assert_not_refactored(
+    assert_ignored(
       ExtractFunction,
       """
       defmodule Foo do

diff --git a/test/refactor/function/inline_function_test.exs b/test/refactor/function/inline_function_test.exs
@@ -536,7 +536,7 @@ defmodule Refactorex.Refactor.Function.InlineFunctionTest do
   end
 
   test "ignores function definition" do
-    assert_not_refactored(
+    assert_ignored(
       InlineFunction,
       """
       defmodule Foo do
@@ -553,7 +553,7 @@ defmodule Refactorex.Refactor.Function.InlineFunctionTest do
   end
 
   test "ignores function call without same module definition" do
-    assert_not_refactored(
+    assert_ignored(
       InlineFunction,
       """
       defmodule Foo do
@@ -568,7 +568,7 @@ defmodule Refactorex.Refactor.Function.InlineFunctionTest do
   end
 
   test "ignores function call outside module" do
-    assert_not_refactored(
+    assert_ignored(
       InlineFunction,
       """
       def foo(arg) do

diff --git a/test/refactor/function/rename_function_test.exs b/test/refactor/function/rename_function_test.exs
@@ -212,7 +212,7 @@ defmodule Refactorex.Refactor.Function.RenameFunctionTest do
   end
 
   test "ignores function when the definition cannot be found" do
-    assert_not_refactored(
+    assert_ignored(
       RenameFunction,
       """
       defmodule Foo do
@@ -227,7 +227,7 @@ defmodule Refactorex.Refactor.Function.RenameFunctionTest do
   end
 
   test "ignores selection outside module" do
-    assert_not_refactored(
+    assert_ignored(
       RenameFunction,
       """
       def foo(arg) do