ATO-1291: Add request object support #233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryan-Andrews99
force-pushed
the
ATO-1291-add-request-objects
branch
2 times, most recently
from
d28bb17 to
2f1dfbf
Compare
cearl1
force-pushed
the
ATO-1291-add-request-objects
branch
2 times, most recently
from
db6a5ac to
9cc9e4b
Compare
Co-authored-by: Ryan Andrews <[email protected]>
Co-authored-by: Ryan Andrews <[email protected]>
Co-authored-by: Ryan Andrews <[email protected]>
Co-authored-by: Ryan Andrews <[email protected]>
Co-authored-by: Ryan Andrews <[email protected]>
Updates the parsing to support auth requests using query parameters and auth requests using request objects. Also renames the files to not be specific to query parameters. Co-authored-by: Ryan Andrews <[email protected]>
Uses new validation in controller, which enables support for request objects. Also throws MethodNotAllowedError for non GET requests Co-authored-by: Ryan Andrews <[email protected]>
Co-authored-by: Craig Earl <[email protected]>
cearl1
force-pushed
the
ATO-1291-add-request-objects
branch
from
9cc9e4b to
ffa42af
Compare
We added it for request object so we need to have the equivalent validation for query params
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds support for using request objects in auth requests.
Also throws
MethodNotAllowedErrorif a request is made that does not use the GET method.Paired with @Ryan-Andrews99