AP-427 add met.police.uk email domain to the onboarding-self-service-experience allow list
#960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove duplicate capitalised domains - sort domains into alphabetic sequence for readability - insert met.police.uk domain
pauldougan
changed the title
met.police.uk email domain to the onboarding-product-page and onboarding-self-service-experience allow listsmet.police.uk email domain to the onboarding-product-page and onboarding-self-service-experience allow lists
pauldougan
changed the title
met.police.uk email domain to the onboarding-product-page and onboarding-self-service-experience allow listsmet.police.uk email domain to the onboarding-self-service-experience allow list
CarlyG55
previously approved these changes
Dec 11, 2024
|
Hi @ethanmills if you can review this it would be helpful and unblock the service team |
CarlyG55
approved these changes
Dec 11, 2024
ethanmills
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AP-427
Onboarding Feature Deployment
Warning
Pull requests merged to
mainwill be released to production, please ensure the checklist below is completeBefore any work can be merged to main in must meet the definition of done and be ready to deploy. While many of these tasks will be automated, the reviewers must take the responsibility of confirming the checklist below has been completed before this ticket can be merged.
Checklist
this pull request meets the acceptance criteria of the ticket
this branch is up-to-date with the main branch
git fetch --all && git rebase origin/mainthese changes are backwards compatible (no breaking changes)
@deprecatedtests have been written to cover any new or updated functionality
new configuration parameters have been deployed to all environments, see configuration management.
all external infrastructure dependencies have been updated in all environments
Changes
[ please list the changes this pull request is making ]
Changedfor changes in existing functionality