ATO- 1063 basic auth secret #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryan-Andrews99
had a problem deploying
to
demo
GitHub Actions
Failure
We're moving these from static content to environment variables, so this passes the values into the render options and derives them from the environment variables.
This removes the basic auth creds from the static content and moves them to be derived from the render options passed in from server side
Ryan-Andrews99
force-pushed
the
ATO-1063-basic-auth-secret
branch
from
8d1d572 to
4e2252a
Compare
Ryan-Andrews99
had a problem deploying
to
demo
GitHub Actions
Failure
Retrieves the environment variables from secrets manager and passes them to the task definition, so that they are available server side when generating static content
Ryan-Andrews99
force-pushed
the
ATO-1063-basic-auth-secret
branch
from
4e2252a to
ce9428e
Compare
CarlyG55
approved these changes
Sep 24, 2024
Ryan-Andrews99
force-pushed
the
ATO-1063-basic-auth-secret
branch
from
ce9428e to
dd6094f
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Ryan-Andrews99
force-pushed
the
ATO-1063-basic-auth-secret
branch
from
dd6094f to
ae0d923
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Ryan-Andrews99
force-pushed
the
ATO-1063-basic-auth-secret
branch
from
ae0d923 to
543b695
Compare
Ryan-Andrews99
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Addedfor new features:Changedfor changes in existing functionalityDeprecatedfor soon-to-be removed featuresRemovedfor now removed features:Fixedfor any bug fixesSecurityin case of vulnerabilitiesNotes:
Two secrets needs to be manually created in each environment before this is deployed