Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INCIDEN-922: Send access token to list client API #894

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

ethanmills
Copy link
Member

This will allow us to ensure the correct user is making the call in a subsequent change

Onboarding Feature Deployment

Warning

Pull requests merged to main will be released to production, please ensure the checklist below is complete

Before any work can be merged to main in must meet the definition of done and be ready to deploy. While many of these tasks will be automated, the reviewers must take the responsibility of confirming the checklist below has been completed before this ticket can be merged.

Checklist

  • this pull request meets the acceptance criteria of the ticket

  • this branch is up-to-date with the main branch

    git fetch --all && git rebase origin/main

  • these changes are backwards compatible (no breaking changes)

    • all methods signatures and return values are the same
    • any replaced methods are marked as @deprecated
  • tests have been written to cover any new or updated functionality

  • new configuration parameters have been deployed to all environments, see configuration management.

  • all external infrastructure dependencies have been updated in all environments

Changes

[ please list the changes this pull request is making ]

Added for new features

Changed for changes in existing functionality

Deprecated for soon-to-be removed features

Removed for now removed features

Fixed for any bug fixes

Security in case of vulnerabilities

This will allow us to ensure the correct user is making the call in a subsequent change
@ethanmills ethanmills requested a review from a team as a code owner September 4, 2024 15:48
@ethanmills ethanmills added this pull request to the merge queue Sep 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 5, 2024
@ethanmills ethanmills added this pull request to the merge queue Sep 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 5, 2024
@ethanmills ethanmills added this pull request to the merge queue Sep 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 5, 2024
@ethanmills ethanmills added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit 4c76e96 Sep 6, 2024
15 of 16 checks passed
@ethanmills ethanmills deleted the inciden-922/access-control branch September 6, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants