ATO-925: Fix double email entry bug #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryan-Andrews99
force-pushed
the
ATO-925-fix-double-email-entry-bug
branch
from
a12d816 to
b2bf246
Compare
ethanmills
reviewed
Jul 24, 2024
kalpaitch
force-pushed
the
ATO-925-fix-double-email-entry-bug
branch
from
b2bf246 to
91b231b
Compare
kalpaitch
approved these changes
Aug 6, 2024
We will need to assert session.save is called so adding this to our mock request object. I have also narrowed the type as object is the incorrect type here as this includes arrays.
The next controller in the user flow, showCheckEmailForm relies on the session containing the email address. However we redirect when submitting the email address, which may happen faster than our session updating, leading to the user being redirected back to the enter-email page. The docs for express-session say "There are some cases where it is useful to call this method (`session.save()`), for example, redirects..."[1] so adding this session.save call in to ensure the session is updated before the redirect occurs. [deploy] [1]- https://expressjs.com/en/resources/middleware/session.html
Ryan-Andrews99
force-pushed
the
ATO-925-fix-double-email-entry-bug
branch
from
91b231b to
3664077
Compare
The AWS sdk has a vunerability in fast-xml parser[1]. This just bumps the underlying dependency. [1]- https://github.com/govuk-one-login/onboarding-self-service-experience/security/dependabot/67
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Onboarding Feature Deployment
Warning
Pull requests merged to
mainwill be released to production, please ensure the checklist below is completeBefore any work can be merged to main in must meet the definition of done and be ready to deploy. While many of these tasks will be automated, the reviewers must take the responsibility of confirming the checklist below has been completed before this ticket can be merged.
Checklist
this pull request meets the acceptance criteria of the ticket
this branch is up-to-date with the main branch
git fetch --all && git rebase origin/mainthese changes are backwards compatible (no breaking changes)
@deprecatedtests have been written to cover any new or updated functionality
new configuration parameters have been deployed to all environments, see configuration management.
all external infrastructure dependencies have been updated in all environments
Changes
[ please list the changes this pull request is making ]
Addedfor new featuresChangedfor changes in existing functionalityDeprecatedfor soon-to-be removed featuresRemovedfor now removed featuresFixedfor any bug fixesSecurityin case of vulnerabilities