-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ATO-695: Allow JWKS URL Configuration #835
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gn-GDS
force-pushed
the
ato-695-allow-jwks-url-configuration
branch
from
July 18, 2024 15:58
1b02cef
to
1dfa59e
Compare
gn-GDS
force-pushed
the
ato-695-allow-jwks-url-configuration
branch
2 times, most recently
from
August 1, 2024 09:55
4391bf6
to
bdc7100
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor fixes with the unit tests, the rest is optional/ just me wondering 😄
- Update change-public-key page to allow either pub key or jwks url - Add jwks validation - Allow setting text value in textAreaInput
gn-GDS
force-pushed
the
ato-695-allow-jwks-url-configuration
branch
from
August 8, 2024 12:35
bdc7100
to
e36ddbd
Compare
Ryan-Andrews99
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Onboarding Feature Deployment
Warning
Pull requests merged to
main
will be released to production, please ensure the checklist below is completeBefore any work can be merged to main in must meet the definition of done and be ready to deploy. While many of these tasks will be automated, the reviewers must take the responsibility of confirming the checklist below has been completed before this ticket can be merged.
Checklist
this pull request meets the acceptance criteria of the ticket
this branch is up-to-date with the main branch
git fetch --all && git rebase origin/main
these changes are backwards compatible (no breaking changes)
@deprecated
tests have been written to cover any new or updated functionality
new configuration parameters have been deployed to all environments, see configuration management.
all external infrastructure dependencies have been updated in all environments
Changes
Added
for new featuresChanged
for changes in existing functionalityDeprecated
for soon-to-be removed featuresRemoved
for now removed featuresFixed
for any bug fixesSecurity
in case of vulnerabilities