Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATO-695: Allow JWKS URL Configuration #835

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

gn-GDS
Copy link
Contributor

@gn-GDS gn-GDS commented Jul 18, 2024

Onboarding Feature Deployment

Warning

Pull requests merged to main will be released to production, please ensure the checklist below is complete

Before any work can be merged to main in must meet the definition of done and be ready to deploy. While many of these tasks will be automated, the reviewers must take the responsibility of confirming the checklist below has been completed before this ticket can be merged.

Checklist

  • this pull request meets the acceptance criteria of the ticket

  • this branch is up-to-date with the main branch

    git fetch --all && git rebase origin/main

  • these changes are backwards compatible (no breaking changes)

    • all methods signatures and return values are the same
    • any replaced methods are marked as @deprecated
  • tests have been written to cover any new or updated functionality

  • new configuration parameters have been deployed to all environments, see configuration management.

  • all external infrastructure dependencies have been updated in all environments

Changes

  • Change public key field to a choice between pubkey and JWKs
  • Conditional reveal radio button between jwks and public key
  • Perform URL validation
  • Update UI automation and unit tests

Added for new features

  • Add jwks validation

Changed for changes in existing functionality

  • Update change-public-key page to allow either pub key or jwks url
  • Allow setting text value in textAreaInput

Deprecated for soon-to-be removed features

Removed for now removed features

Fixed for any bug fixes

Security in case of vulnerabilities

Copy link
Contributor

@Ryan-Andrews99 Ryan-Andrews99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor fixes with the unit tests, the rest is optional/ just me wondering 😄

express/@types/client.d.ts Outdated Show resolved Hide resolved
express/src/controllers/clients.ts Show resolved Hide resolved
express/src/views/macros/form-inputs.njk Show resolved Hide resolved
express/src/controllers/register.ts Outdated Show resolved Hide resolved
- Update change-public-key page to allow either pub key or jwks url
- Add jwks validation
- Allow setting text value in textAreaInput
@gn-GDS gn-GDS force-pushed the ato-695-allow-jwks-url-configuration branch from bdc7100 to e36ddbd Compare August 8, 2024 12:35
@gn-GDS gn-GDS requested a review from Ryan-Andrews99 August 8, 2024 13:21
@kalpaitch kalpaitch added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit b91b1e9 Aug 8, 2024
16 checks passed
@kalpaitch kalpaitch deleted the ato-695-allow-jwks-url-configuration branch August 8, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants