Skip to content

Commit

Permalink
BAU: remove aws-sdk-mock and sinon
Browse files Browse the repository at this point in the history
There is a critical vunerability[1] in a package which both these
depenencies depend on. Currently there is no fix available, however
these either:
- In the case of the SDK mocks, a nice to have not a required
- In the case of sinon, not used
- Both are just testing dependecies

So I have dedcided to remove them, given the npm audit check is
currently blocking.

[1]- GHSA-9wv6-86v2-598j
  • Loading branch information
Ryan-Andrews99 committed Sep 10, 2024
1 parent d1b3827 commit 1d66774
Show file tree
Hide file tree
Showing 3 changed files with 98 additions and 206 deletions.
6 changes: 1 addition & 5 deletions backend/api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,9 @@
"@aws-sdk/util-dynamodb": "^3.624.0",
"@aws-lambda-powertools/logger": "2.6.0",
"axios": "^1.7.4",
"esbuild": "^0.23.0",
"sinon": "^17.0.1"
"esbuild": "^0.23.0"
},
"devDependencies": {
"@types/sinon": "^17.0.3",
"aws-sdk-client-mock": "^4.0.0",
"aws-sdk-client-mock-jest": "^4.0.0",
"axios-mock-adapter": "^2.0.0"
}
}
4 changes: 1 addition & 3 deletions express/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@
"nodemon": "^3.0.1",
"sass": "^1.60.0",
"typescript": "^5.5.2",
"uglify-js": "^3.19.2",
"aws-sdk-client-mock": "^4.0.0",
"aws-sdk-client-mock-jest": "^4.0.0"
"uglify-js": "^3.19.2"
}
}
Loading

0 comments on commit 1d66774

Please sign in to comment.