-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DCMAW-10829: Get biometric access token from ReadID #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmooney-dd
commented
Jan 15, 2025
backend-api/src/functions/asyncBiometricToken/getBiometricToken/getBiometricToken.test.ts
Outdated
Show resolved
Hide resolved
jmooney-dd
commented
Jan 15, 2025
backend-api/src/functions/asyncBiometricToken/getBiometricToken/getBiometricToken.ts
Outdated
Show resolved
Hide resolved
jmooney-dd
changed the title
DCMAW-10829
DCMAW-10829: Get biometric access token from ReadID
Jan 15, 2025
jmooney-dd
commented
Jan 15, 2025
backend-api/src/functions/asyncBiometricToken/getBiometricToken/getBiometricToken.ts
Outdated
Show resolved
Hide resolved
backend-api/src/functions/asyncBiometricToken/getBiometricToken/getBiometricToken.ts
Outdated
Show resolved
Hide resolved
backend-api/src/functions/asyncBiometricToken/getBiometricToken/getBiometricToken.ts
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
chris-cooksley-gds
approved these changes
Jan 16, 2025
mthkbarber
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DCMAW-10829
What changed
getBiometricToken()
to send request to ReadID's/token
endpoint withsubmitterKey
to retrieve biometric access tokenPOST
functionality insendHttpRequest()
template.yaml
to use v2 of ReadID mockMOBILE_ASYNC_BIOMETRIC_TOKEN_GET_BIOMETRIC_TOKEN_FROM_READID_ATTEMPT
level: "debug"
- will only appear indev
MOBILE_ASYNC_BIOMETRIC_TOKEN_GET_BIOMETRIC_TOKEN_FROM_READID_FAILURE
level: "error"
- will appear in all environmentsMOBILE_ASYNC_BIOMETRIC_TOKEN_GET_BIOMETRIC_TOKEN_FROM_READID_SUCCESS
level: "debug"
- will only appear indev
Why did it change
ReadID host a
/token
endpoint. This used for exchanging the submitter access key for a temporary access key that is scoped for use by the mobile apps. The submitter access keys have been retrievedNext steps
This PR covers the logic required to get a biometric access token from ReadID however a follow-up PR will be raised to adapt
sendHttpRequest()
to allow for an exponential backoff retry policy, currently it is staticEvidence
Manual testing
First time integrating with our ReadID Mock in this account so made a real request to it and confirmed I received the expected response from the mock
Automation testing
Deployed stack and ran
api
tests - all passingNew log messages
MOBILE_ASYNC_BIOMETRIC_TOKEN_GET_BIOMETRIC_TOKEN_FROM_READID_ATTEMPT
MOBILE_ASYNC_BIOMETRIC_TOKEN_GET_BIOMETRIC_TOKEN_FROM_READID_FAILURE
MOBILE_ASYNC_BIOMETRIC_TOKEN_GET_BIOMETRIC_TOKEN_FROM_READID_SUCCESS
Checklists