[DCMAW-11018] Use new certificates #336
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dothomson
reviewed
Jan 15, 2025
backend-api/template.yaml
Outdated
| @@ -224,6 +224,10 @@ Conditions: | |||
| - !Ref Environment | |||
| - build | |||
|
|
|||
| useWildcardCertificate: !Equals | |||
There was a problem hiding this comment.
Could also check that ${AWS::StackName} != 'mob-async-backend' so that the auto dev deployment uses the BaseCertificate.
There was a problem hiding this comment.
oooo okay will look
There was a problem hiding this comment.
Does this mean that if the stack name isn't mob-async-backend then it'll add a wildcard. Is that a bit open?
There was a problem hiding this comment.
Only if it is also dev!
!And
- !Equals [!Ref Environment, "dev]
- !Not [!Equals [!Ref AWS::StackName, "mob-async-backend"]]
or something
kikidawson-gds
force-pushed
the
DCMAW-11018
branch
from
b2ba0f0 to
9d2c63b
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DCMAW-11018
What changed
Updates regional certs to point to either wildcard cert if dev, or proxy/base cert
Why did it change
Current set up is fiddly to add new domains.
https://github.com/govuk-one-login/mobile-id-check-readid-mock/pull/15
https://github.com/govuk-one-login/mobile-id-check-async-infra/pull/13
See async infra PR for testing screenshots
Checklists