ci: Allow pull request workflow to run for any base branch #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem Github Actions workflows do not run for stacked PRs where the base branch is an unmerged branch and not `main`. ## Solution Allow the PR workflow to run for any base branch.
|
1 similar comment
|
obinns-dd
reviewed
Jan 17, 2025
| @@ -1,8 +1,6 @@ | |||
| name: On Pull Request | |||
| on: | |||
| pull_request: | |||
| branches: | |||
| - main | |||
There was a problem hiding this comment.
rather than merging pull requests together, would we not be better off merging pull request 1, then rebasing pull request 2 from main?
There was a problem hiding this comment.
In general I think we should be striving to finish one piece of work before moving onto the next 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Github Actions workflows do not run for stacked PRs where the base branch is an unmerged branch and not
main.Solution
Allow the PR workflow to run for any base branch.