Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The stack name needs to be limited at 34 #138

Merged
merged 3 commits into from
Nov 21, 2024
Merged

The stack name needs to be limited at 34 #138

merged 3 commits into from
Nov 21, 2024

Conversation

TobySaundersGDS
Copy link
Contributor

@TobySaundersGDS TobySaundersGDS commented Nov 15, 2024 •
edited
Loading

prefix is 20 chars, max Lambda function name length is 64, the lambdas in this template use prefix-stackname-resource-name so limiting prefix-stackname to 34 char leaving 30 for resource names

Proposed changes

My last PR failed checked with this error:

CREATE_FAILED            AWS::Lambda::Function    AnswerValidationFuncti   Resource handler       
                                                  on                       returned message: "1   
                                                                           validation error       
                                                                           detected: Value        
                                                                           'preview-kbv-hmrc-api- 
                                                                           psredev-1911-dev-      
                                                                           platform-support-      
                                                                           request-adam-          
                                                                           higginson-answer-      
                                                                           validation' at         
                                                                           'functionName' failed  
                                                                           to satisfy constraint: 
                                                                           Member must have       
                                                                           length less than or    
                                                                           equal to 64 (Service:  
                                                                           Lambda, Status Code:   
                                                                           400, Request ID: e3a52 
                                                                           f93-3b98-4115-adcf-    
                                                                           072de2e5218c)"         
                                                                           (RequestToken: ea6d8a7 
                                                                           9-cfb9-7038-04e4-      
                                                                           6cc8255ccc2b,          
                                                                           HandlerErrorCode:      
                                                                           InvalidRequest)

What changed

Why did it change

Issue tracking

Other considerations

@TobySaundersGDS
The stack name needs to be limited at 44
527ecdf 
prefix is 20 chars, max Lambda function name length is 64
@TobySaundersGDS TobySaundersGDS requested review from a team as code owners November 15, 2024 16:37
@TobySaundersGDS
The stack name needs to be limited at 24
34a672e 
prefix is 20 chars, max Lambda function name length is 64 and the template appends the prefix, the branch name and the resource name to make the  lambda function name
@TobySaundersGDS
The stack name needs to be limited at 34
a90e05f 
prefix is 20 chars, max Lambda function name length is 64 and the template appends the prefix, some of the branch name and the resource name to make the lambda function name, gives a max 30 chars function name
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@TobySaundersGDS TobySaundersGDS changed the title The stack name needs to be limited at 44 The stack name needs to be limited at 34 Nov 15, 2024
@TobySaundersGDS TobySaundersGDS merged commit 3480aef into main Nov 21, 2024
14 checks passed
@TobySaundersGDS TobySaundersGDS deleted the bau-fix-long-lambda-name-error branch November 21, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrdoodles mrdoodles mrdoodles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TobySaundersGDS @mrdoodles