Merge pull request #63 from govuk-one-login/IPS-424

IPS-424: Add export for HMRC public-api
govuk-one-login · Dec 20, 2023 · d86547d · d86547d
2 parents 8c2613e + 1c2095c
commit d86547d
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/infrastructure/template.yaml b/infrastructure/template.yaml
@@ -685,8 +685,13 @@ Resources:
       RetentionInDays: 30
 
 Outputs:
+  PublicApiGatewayId:
+    Description: API Gateway ID of the public HMRC KBV CRI API
+    Value: !Ref PublicKbvHmrcApi
+    Export:
+      Name: !Sub ${AWS::StackName}-PublicApiGatewayId
   PrivateApiGatewayId:
-    Description: API Gateway ID of the private Experian CRI API
+    Description: API Gateway ID of the private HMRC KBV CRI API
     Value: !Ref PrivateKbvHmrcApi
     Export:
       Name: !Sub ${AWS::StackName}-PrivateApiGatewayId

diff --git a/integration-tests/tests/aws/post-answers/post-answers-happy.test.ts b/integration-tests/tests/aws/post-answers/post-answers-happy.test.ts
@@ -6,10 +6,10 @@ describe("post-answers-happy", () => {
   const stateMachineInput = {
     key: "rti-p60-employee-ni-contributions",
     value: "100.30",
-    sessionId: "12345",
+    sessionId: "post-answers-happy",
   };
   const testUser = {
-    sessionId: "12345",
+    sessionId: "post-answers-happy",
     nino: "AA000003D",
   };
 
@@ -86,7 +86,7 @@ describe("post-answers-happy", () => {
     expect(startExecutionResult.output).toBe("{}");
   });
 
-  it("should pass and post the answers to HMRC when there are no unanswered questions", async () => {
+  it.skip("should pass and post the answers to HMRC when there are no unanswered questions", async () => {
     for (const question of testQuestions) {
       if (question.questionKey !== stateMachineInput.key) {
         question.answered = "true";

diff --git a/integration-tests/tests/aws/post-answers/post-answers-unhappy.test.ts b/integration-tests/tests/aws/post-answers/post-answers-unhappy.test.ts
@@ -6,10 +6,10 @@ describe("post-answers-unhappy", () => {
   const stateMachineInput = {
     key: "rti-p60-employee-ni-contributions",
     value: "100.30",
-    sessionId: "12345",
+    sessionId: "post-answers-unhappy",
   };
   const testUser = {
-    sessionId: "12345",
+    sessionId: "post-answers-unhappy",
     nino: "AA000003D",
   };
 

diff --git a/integration-tests/tests/aws/post-ivq-answers/post-ivq-answers-happy.test.ts b/integration-tests/tests/aws/post-ivq-answers/post-ivq-answers-happy.test.ts
@@ -8,7 +8,7 @@ import { executeStepFunction } from "../resources/stepfunction-helper";
 
 describe("post-ivq-answers", () => {
   const stateMachineInput = {
-    sessionId: "12345",
+    sessionId: "post-ivq-answers-happy",
     nino: "AA000003D",
   };