Merge pull request #379 from govuk-one-login/KIWI-1638-ci-change

KIWI-1638: Updates CI for DOC_NUMBER_INVALID
govuk-one-login · Mar 6, 2024 · d24c219 · d24c219
2 parents 8cb050f + a7c834e
commit d24c219
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/src/services/GenerateVerifiableCredential.ts b/src/services/GenerateVerifiableCredential.ts
@@ -164,6 +164,7 @@ export class GenerateVerifiableCredential {
   				case "TAMPERED":
   				case "MISSING_HOLOGRAM":
   				case "NO_HOLOGRAM_MOVEMENT":
+  				case "DOC_NUMBER_INVALID":
   					contraIndicator = "D14";
   					break;
   				case "EXPIRED_DOCUMENT":
@@ -172,9 +173,6 @@ export class GenerateVerifiableCredential {
   				case "FRAUD_LIST_MATCH":
   					contraIndicator = "F03";
   					break;
-  				case "DOC_NUMBER_INVALID":
-  					contraIndicator = "D02";
-  					break;
   				case "DATA_MISMATCH":
   				case "CHIP_DATA_INTEGRITY_FAILED":
   				case "CHIP_SIGNATURE_VERIFICATION_FAILED":

diff --git a/src/tests/data/vcValidationData.json b/src/tests/data/vcValidationData.json
@@ -184,7 +184,7 @@
         "verificationScore": 0,
         "checkMethod": null,
         "failedCheck": "DOC_NUMBER_INVALID",
-        "ci": "D02"
+        "ci": "D14"
     },
     "s0123":{
         "strengthScore": null,

diff --git a/src/tests/unit/services/GenerateVerifiableCredential.test.ts b/src/tests/unit/services/GenerateVerifiableCredential.test.ts
@@ -220,7 +220,7 @@ describe("GenerateVerifiableCredential", () => {
 			{ reason: "COUNTERFEIT", contraIndicator: ["D14"] },
 			{ reason: "EXPIRED_DOCUMENT", contraIndicator: ["D16"] },
 			{ reason: "FRAUD_LIST_MATCH", contraIndicator: ["F03"] },
-			{ reason: "DOC_NUMBER_INVALID", contraIndicator: ["D02"] },
+			{ reason: "DOC_NUMBER_INVALID", contraIndicator: ["D14"] },
 			{ reason: "TAMPERED", contraIndicator: ["D14"] },
 			{ reason: "MISSING_HOLOGRAM", contraIndicator: ["D14"] },
 			{ reason: "NO_HOLOGRAM_MOVEMENT", contraIndicator: ["D14"] },