Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OJ-2837: Feat - update tests to use multiple names scenario #515

Merged
merged 3 commits into from
Nov 28, 2024
Merged

OJ-2837: Feat - update tests to use multiple names scenario #515

merged 3 commits into from
Nov 28, 2024

Conversation

MarieseMikely
Copy link
Contributor

@MarieseMikely MarieseMikely commented Nov 26, 2024 •
edited
Loading

Proposed changes

What changed

  • Added conditional to include multiple names in the payload based on tests
  • Used test-user 201 from UAT spreadsheet

console log with the multiple named user to ensure its being sent:
Screenshot 2024-11-26 at 18 14 17

console log to ensure defaulted claimset is being used when not updated:
Screenshot 2024-11-26 at 18 14 36

Why did it change

Increase test coverage

Issue tracking

Checklists

Environment variables or secrets

  • No environment variables or secrets were added or changed

Other considerations

  • Update README with any new instructions or tasks

@MarieseMikely MarieseMikely force-pushed the OJ-2837-multiple-name-test branch from ec38843 to 3cc194a Compare November 26, 2024 12:01
@MarieseMikely MarieseMikely force-pushed the OJ-2837-multiple-name-test branch from c97fe50 to 1929e9c Compare November 26, 2024 12:43
@MarieseMikely MarieseMikely force-pushed the OJ-2837-multiple-name-test branch from 23150ce to 7be459e Compare November 26, 2024 18:20
@MarieseMikely MarieseMikely force-pushed the OJ-2837-multiple-name-test branch from 7be459e to 7518e30 Compare November 26, 2024 18:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Caitlin-cooling
Caitlin-cooling approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@Caitlin-cooling Caitlin-cooling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MarieseMikely MarieseMikely merged commit eb4718e into main Nov 28, 2024
16 checks passed
@MarieseMikely MarieseMikely deleted the OJ-2837-multiple-name-test branch November 28, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surajkumar surajkumar surajkumar left review comments

@Caitlin-cooling Caitlin-cooling Caitlin-cooling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarieseMikely @Caitlin-cooling @surajkumar