OJ-2897: Remove redaction of lambda and API log groups #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caitlin-cooling
had a problem deploying
to
development
GitHub Actions
Failure
Caitlin-cooling
temporarily deployed
to
development
GitHub Actions
Inactive
Caitlin-cooling
had a problem deploying
to
development
GitHub Actions
Failure
Caitlin-cooling
temporarily deployed
to
development
GitHub Actions
Inactive
Caitlin-cooling
had a problem deploying
to
development
GitHub Actions
Failure
CharlesIC
approved these changes
Nov 1, 2024
Caitlin-cooling
temporarily deployed
to
development
GitHub Actions
Inactive
Caitlin-cooling
temporarily deployed
to
development
GitHub Actions
Inactive
Caitlin-cooling
temporarily deployed
to
development
GitHub Actions
Inactive
Caitlin-cooling
temporarily deployed
to
development
GitHub Actions
Inactive
Caitlin-cooling
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
What changed
Why did it change
Because these are logs we have control over we do not need to redact them, we should just not be logging PII. The redaction is only completely necessary for step functions where we can't control the log output.
This should reduce the amount of logs that are having to be processed and pushed to cloudwatch and help us avoid rate limit issues
Issue tracking