PYIC-7797: route failed + reverification journeys to use process-candidate-identity-lambda #2867

thebauSoftwire · 2025-01-13T18:00:19Z

Proposed changes

What changed

Added routing to failed and reverification journeys to use new process-candidate-identity lambda

Why did it change

We made a new lambda to consolidate a bunch of other lambdas, this PR uses that lambda on journeys that don't yet use it yet.

Issue tracking

PYIC-7797

lambdas/process-journey-event/src/main/resources/statemachine/journey-maps/failed.yaml

thebauSoftwire · 2025-01-13T18:09:14Z

We also have operational profile migration/reuse journeys which call only the call-ticf-cri lambda. The only identityType which suits this is the INCOMPLETE one which doesn't it because it's not an incomplete identity. We could instead add a OPERATIONAL identityType?

thebauSoftwire · 2025-01-13T18:18:33Z

local-running/core.local.params.yaml

@@ -389,7 +389,7 @@ core:
    sqsAsync: true
    kidJarHeaderEnabled: true
    drivingLicenceAuthCheck: false
-    processCandidateIdentity: false
+    processCandidateIdentity: true


still having difficulty running the api tests consistently locally, fetch is now failing at initialise ipv session :( so testing here and leaving this comment as a note to self to remove this when ready to be merged

Joe-Edwards-GDS · 2025-01-14T09:37:51Z

lambdas/process-journey-event/src/main/resources/statemachine/journey-maps/failed.yaml

@@ -33,6 +39,20 @@ states:
              - IPV_USER_DETAILS_UPDATE_END
            auditContext:
              successful: false
+            checkFeatureFlag:
+              processCandidateIdentity:
+                targetState: PROCESS_INCOMPLETE_IDENTITY_COULD_NOT_CONFIRM_WITH_DELETION_INVALID_ID


Do we need the 'with deletion' any more? - It's fine, but these super long state names feel a bit awkward!

Sadly, I don't think we can update the existing states without a two-step deploy

I've changed the new ones but haven't updated the others. For my own learning, what would a two step deployment look like for updating the existing states and why do we need it?

Let's say you had:

FIRST: events: next: targetState: SECOND SECOND: events: next: targetState: THIRD THIRD: ...

and you want to rename SECOND...

You'd need to do it in two steps:

FIRST: events: next: targetState: SECOND_NEW SECOND_NEW: events: next: targetState: THIRD SECOND: events: next: targetState: THIRD THIRD: ...

and then

FIRST: events: next: targetState: SECOND_NEW SECOND_NEW: events: next: targetState: THIRD THIRD: ...

The reason is that users might be in SECOND when you deploy the first change, so the journey map still needs to know about it (otherwise they'll get 'unexpected state' when trying to continue).

If it's a very quick state (e.g. a process state) then the window for this is only a few seconds, and we might be able to get away without the two steps, but if it's a CRI state, then it could cause quite a few errors.

thanks for explaining :) I've made the changes now to do the two-step deployment

lambdas/process-journey-event/src/main/resources/statemachine/journey-maps/failed.yaml

Joe-Edwards-GDS · 2025-01-14T09:40:35Z

lambdas/process-journey-event/src/main/resources/statemachine/journey-maps/failed.yaml

+      alternate-doc-invalid-dl:
+        targetState: COULD_NOT_CONFIRM_DETAILS_PAGE_WITH_DELETION_VALID_ID
+      alternate-doc-invalid-passport:
+        targetState: COULD_NOT_CONFIRM_DETAILS_PAGE_WITH_DELETION_VALID_ID


(Happy to leave since it's unchanged but this looks a bit odd - if you've got an outstanding CI here, surely the ID is not valid 🤔)

ah didn't notice this that's a good point 👀

Joe-Edwards-GDS · 2025-01-14T09:40:59Z

lambdas/process-journey-event/src/main/resources/statemachine/journey-maps/failed.yaml

+      alternate-doc-invalid-dl:
+        targetState: COULD_NOT_UPDATE_DETAILS_PAGE
+      alternate-doc-invalid-passport:
+        targetState: COULD_NOT_UPDATE_DETAILS_PAGE


lambdas/process-journey-event/src/main/resources/statemachine/journey-maps/failed.yaml

thebauSoftwire · 2025-01-15T09:03:55Z

All existing api tests passed 🟢 I've only turned on the processCandidateIdentity feature set for the audit events as those changed with the routing changes when introducing the new lambda. Only have one audit event test to fix related to the process-async-credential lambda

Joe-Edwards-GDS

Looks good - a couple of things flagged up by the audit event tests :)

api-tests/data/audit-events/delete-pending-f2f-journey.json

Joe-Edwards-GDS · 2025-01-15T17:18:45Z

api-tests/data/audit-events/new-identity-f2f-journey.json

+    }
+  },
+  {
+    "event_name": "IPV_GPG45_PROFILE_MATCHED",


Hmm, this one actually makes me a little nervous - it means we'll record this event twice (you can see it a couple of events up as well)...

I wonder if we should remove the profile matched event from check-existing-identity, and rely on this to do it, when the feature is enabled? - Will that drop it from any other scenarios?

Joe-Edwards-GDS · 2025-01-15T17:20:31Z

api-tests/data/audit-events/new-identity-p2-app-journey.json

@@ -222,7 +252,7 @@
    "event_name": "IPV_IDENTITY_STORED",
    "component_id": "https://identity.local.account.gov.uk",
    "extensions": {
-      "identity_type": "new",
+      "identity_type": "NEW",


This is interesting - is this a deliberate difference?

Looks like IdentityType has a JsonProperty annotation to make it lowercase, but CandidateIdentityType doesn't?

Perhaps we need to add similar annotations, or map one onto the other here...

Exactly the sort of issue we would have missed without these tests!

api-tests/features/audit-events.feature

Joe-Edwards-GDS · 2025-01-15T17:23:14Z

lambdas/process-journey-event/src/main/resources/statemachine/journey-maps/failed.yaml

Looking forward to the cleanup here!

… lambda

…ntity lambda

…ning

… identity lambda

… events api tests

…ailing test" This reverts commit 9727cc3.

…ityType with annotations

…ity if processCandidateIdentity is enabled + update api tests

Joe-Edwards-GDS

I think this is good, just a couple of typos :)

Joe-Edwards-GDS · 2025-01-17T09:13:16Z

api-tests/src/steps/ipv-steps.ts

-  "I activate the {string} feature set(s)",
-  function (this: World, featureSet: string) {
-    this.featureSet = featureSet;
+  /I activate the '([\w,]+)' feature set(?:s)?( along with the existing feature set(?:s)?)?/,


(I sort of wonder if this should be the default, but neat either way!)

good idea 👍

Joe-Edwards-GDS · 2025-01-17T09:14:20Z

api-tests/data/audit-events/new-identity-p2-app-journey.json

@@ -142,7 +142,7 @@
        }
      ],
      "successful": true,
-      "age": "type[number]"
+      "age": 59


(accidental reversion here)

Joe-Edwards-GDS · 2025-01-17T09:15:06Z

api-tests/features/audit-events.feature

@@ -76,7 +79,7 @@ Feature: Audit Events
      | evidence_requested | {"scoringPolicy":"gpg45","strengthScore":3} |
    Then I get a 'page-face-to-face-handoff' page response

-    Given I activate the 'pendingF2FResetEnabled' feature set
+    Given I activate the 'pendingF2FResetEnabled' feature set along with the e


sonarqubecloud · 2025-01-17T17:03:19Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

thebauSoftwire commented Jan 13, 2025

View reviewed changes

lambdas/process-journey-event/src/main/resources/statemachine/journey-maps/failed.yaml Show resolved Hide resolved

thebauSoftwire commented Jan 13, 2025

View reviewed changes

lambdas/process-journey-event/src/main/resources/statemachine/journey-maps/failed.yaml Show resolved Hide resolved

thebauSoftwire commented Jan 13, 2025

View reviewed changes

Joe-Edwards-GDS reviewed Jan 14, 2025

View reviewed changes

thebauSoftwire force-pushed the pyic-7797-route-failed-journeys branch from c27b345 to 870abd6 Compare January 15, 2025 09:35

Joe-Edwards-GDS reviewed Jan 15, 2025

View reviewed changes

thebauSoftwire marked this pull request as ready for review January 16, 2025 13:09

thebauSoftwire requested review from a team as code owners January 16, 2025 13:09

thebauSoftwire requested a review from Joe-Edwards-GDS January 16, 2025 13:09

thebauSoftwire added 16 commits January 17, 2025 09:08

PYIC-7797: update failed subjourney to use process candidate identity…

95e33ac

… lambda

PYIC-7797: update reverification journey to use process candidate ide…

63c0523

…ntity lambda

PYIC-7797: fix indentation on failed journey map

637f2c5

PYIC-7797: TEST setting processCandidateIdentity to true in local run…

5b4f531

…ning

PYIC-7797: update reverification and failed journeys

4a456e5

PYIC-7797: update new state names for failed journey

48cc502

PYIC-7797: update operational profile journeys with process candidate…

e121d7d

… identity lambda

PYIC-7797: rename states to remove _with_details_prefex

dc66ee9

PYIC-7797: fix failing ProcessCandidateIdentityHandlerTest

004c9ce

PYIC-7797: update audit event api tests

8b7f680

PYIC-7797: fix sonar

b66ddee

PYIC-7797: turning on processCandidateIdentity feature flag for audit…

5233855

… events api tests

PYIC-7797: TEST to print out what the actual events are for failing test

b596ecd

Revert "PYIC-7797: TEST to print out what the actual events are for f…

1be103c

…ailing test" This reverts commit 9727cc3.

PYIC-7797: update feature set cucumber step and update CandidateIdent…

1282467

…ityType with annotations

PYIC-7797: remove IPV_GPG45_PROFILE_MATCHED from check-existing-ident…

3fd74bd

…ity if processCandidateIdentity is enabled + update api tests

Joe-Edwards-GDS reviewed Jan 17, 2025

View reviewed changes

PYIC-7797: fix typos and set default to append to existing features set

eb04486

thebauSoftwire force-pushed the pyic-7797-route-failed-journeys branch from 5806401 to eb04486 Compare January 17, 2025 16:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PYIC-7797: route failed + reverification journeys to use process-candidate-identity-lambda #2867

PYIC-7797: route failed + reverification journeys to use process-candidate-identity-lambda #2867

thebauSoftwire commented Jan 13, 2025 •

edited by jira bot

Loading

thebauSoftwire commented Jan 13, 2025

thebauSoftwire Jan 13, 2025

Joe-Edwards-GDS Jan 14, 2025 •

edited

Loading

thebauSoftwire Jan 14, 2025

Joe-Edwards-GDS Jan 14, 2025

thebauSoftwire Jan 15, 2025

Joe-Edwards-GDS Jan 14, 2025

thebauSoftwire Jan 14, 2025

Joe-Edwards-GDS Jan 14, 2025

thebauSoftwire commented Jan 15, 2025 •

edited

Loading

Joe-Edwards-GDS left a comment

Joe-Edwards-GDS Jan 15, 2025

Joe-Edwards-GDS Jan 15, 2025

Joe-Edwards-GDS Jan 15, 2025

Joe-Edwards-GDS Jan 15, 2025

Joe-Edwards-GDS left a comment

Joe-Edwards-GDS Jan 17, 2025

thebauSoftwire Jan 17, 2025

Joe-Edwards-GDS Jan 17, 2025

Joe-Edwards-GDS Jan 17, 2025

sonarqubecloud bot commented Jan 17, 2025

PYIC-7797: route failed + reverification journeys to use process-candidate-identity-lambda #2867

Are you sure you want to change the base?

PYIC-7797: route failed + reverification journeys to use process-candidate-identity-lambda #2867

Conversation

thebauSoftwire commented Jan 13, 2025 • edited by jira bot Loading

Proposed changes

What changed

Why did it change

Issue tracking

thebauSoftwire commented Jan 13, 2025

Choose a reason for hiding this comment

Joe-Edwards-GDS Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thebauSoftwire commented Jan 15, 2025 • edited Loading

Joe-Edwards-GDS left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Joe-Edwards-GDS left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 17, 2025

Quality Gate passed

thebauSoftwire commented Jan 13, 2025 •

edited by jira bot

Loading

Joe-Edwards-GDS Jan 14, 2025 •

edited

Loading

thebauSoftwire commented Jan 15, 2025 •

edited

Loading