-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PYIC-6240: Update async CRI audit events #2657
base: main
Are you sure you want to change the base?
Conversation
How are these changes tested against TxMA to make sure that they correctly match the event catalogue changes? |
...main/java/uk/gov/di/ipv/core/processasynccricredential/ProcessAsyncCriCredentialHandler.java
Outdated
Show resolved
Hide resolved
In the past TxMA have usually tested the event in staging (or asked us to test and checked the audit logs) |
Quality Gate passedIssues Measures |
Reminder to have checked with F2F (if Data haven't already) as they're listed as a consumer of IPV_F2F_CRI_VC_CONSUMED |
https://github.com/govuk-one-login/event-catalogue/pull/291 has now been merged, but we should wait until consumers of the F2F events have updated to understand the new events before merging this PR. |
Conversation with F2F team: https://gds.slack.com/archives/C0440GZHUUX/p1732201961748279 |
Also need to wait for analytics to update their code to accept the new event. Conversation: https://gds.slack.com/archives/C07B1M3FJ67/p1730386568411759 |
DO NOT MERGE before https://github.com/govuk-one-login/event-catalogue/pull/291
Also wait for go-ahead from Analytics and Kiwi
Proposed changes
What changed
Migrate F2F async cri audit events to just async cri events
Why did it change
In preparation for the DCMAW async CRI
Issue tracking