Pyic 7650 international address fraud route (#2803)

govuk-one-login · Dec 18, 2024 · f4b63d5 · f4b63d5
2 parents fcdf16c + 3d672c9
commit f4b63d5
Show file tree

Hide file tree

Showing 40 changed files with 548 additions and 152 deletions.
diff --git a/.github/workflows/pre-merge-checks.yml b/.github/workflows/pre-merge-checks.yml
@@ -164,6 +164,7 @@ jobs:
       - name: Local API tests
         env:
           ASYNC_QUEUE_NAME: ${{ steps.extract_queue_name.outputs.queue_name }}
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           MANAGEMENT_CIMIT_STUB_API_KEY: ${{ secrets.MANAGEMENT_CIMIT_STUB_API_KEY }}
           EVCS_STUB_API_KEY: ${{ secrets.API_KEY_EVCS }}
           CRI_STUB_GEN_CRED_API_KEY: ${{ secrets.CRI_STUB_GEN_CRED_API_KEY }}

diff --git a/api-tests/README.md b/api-tests/README.md
@@ -22,7 +22,7 @@ There are 3 presets that can be used:
 - `npm run test:local` - runs against an already-running local instance of core-back
 - `npm run test:ci` - starts a new local instance of core-back and tests against it
 
-Additional arguments can be passed to cucumber, e.g. to include specific tests: `npm test:local -- --name 'F2F'`
+Additional arguments can be passed to cucumber, e.g. to include specific tests: `npm run test:local -- --name 'F2F'`
 
 If you are using custom configuration, then you can use `npm test` to invoke cucumber without any presets.
 

diff --git a/api-tests/data/cri-stub-requests/dcmaw/alice-passport-valid/evidence.json b/api-tests/data/cri-stub-requests/dcmaw/alice-passport-valid/evidence.json
@@ -9,7 +9,7 @@
       "checkMethod": "bvr"
     }
   ],
-  "validityScore": 2,
+  "validityScore": 3,
   "strengthScore": 4,
   "type": "IdentityCheck"
 }
diff --git a/...sts/data/cri-stub-requests/dcmaw/kenneth-changed-family-name-passport-valid/evidence.json b/...sts/data/cri-stub-requests/dcmaw/kenneth-changed-family-name-passport-valid/evidence.json
@@ -9,7 +9,7 @@
       "checkMethod": "bvr"
     }
   ],
-  "validityScore": 2,
+  "validityScore": 3,
   "strengthScore": 4,
   "type": "IdentityCheck"
 }
diff --git a/...ests/data/cri-stub-requests/dcmaw/kenneth-changed-given-name-passport-valid/evidence.json b/...ests/data/cri-stub-requests/dcmaw/kenneth-changed-given-name-passport-valid/evidence.json
@@ -9,7 +9,7 @@
       "checkMethod": "bvr"
     }
   ],
-  "validityScore": 2,
-  "strengthScore": 3,
+  "validityScore": 3,
+  "strengthScore": 4,
   "type": "IdentityCheck"
 }
diff --git a/api-tests/data/cri-stub-requests/dcmaw/kenneth-passport-valid/evidence.json b/api-tests/data/cri-stub-requests/dcmaw/kenneth-passport-valid/evidence.json
@@ -9,7 +9,7 @@
       "checkMethod": "bvr"
     }
   ],
-  "validityScore": 2,
+  "validityScore": 3,
   "strengthScore": 4,
   "type": "IdentityCheck"
 }
diff --git a/api-tests/data/cri-stub-requests/dcmaw/kenneth-passport-verification-zero/evidence.json b/api-tests/data/cri-stub-requests/dcmaw/kenneth-passport-verification-zero/evidence.json
@@ -1,6 +1,6 @@
 {
   "type": "IdentityCheck",
-  "validityScore": 2,
+  "validityScore": 3,
   "strengthScore": 4,
   "failedCheckDetails": [
     {

diff --git a/...quests/fraud/kenneth-changed-family-name-and-address-no-applicable/credentialSubject.json b/...quests/fraud/kenneth-changed-family-name-and-address-no-applicable/credentialSubject.json
@@ -0,0 +1,34 @@
+{
+  "address": [
+    {
+      "addressCountry": "GB",
+      "uprn": 100120012047,
+      "buildingName": "",
+      "streetName": "King Road",
+      "postalCode": "BS9 6NR",
+      "buildingNumber": "28",
+      "addressLocality": "BRISTOL",
+      "validFrom": "1000-01-01",
+      "subBuildingName": ""
+    }
+  ],
+  "name": [
+    {
+      "nameParts": [
+        {
+          "type": "GivenName",
+          "value": "KENNETH"
+        },
+        {
+          "type": "FamilyName",
+          "value": "SMITH"
+        }
+      ]
+    }
+  ],
+  "birthDate": [
+    {
+      "value": "1965-07-08"
+    }
+  ]
+}
diff --git a/...i-stub-requests/fraud/kenneth-changed-family-name-and-address-no-applicable/evidence.json b/...i-stub-requests/fraud/kenneth-changed-family-name-and-address-no-applicable/evidence.json
@@ -0,0 +1,10 @@
+{
+  "failedCheckDetails": [
+    {
+      "checkMethod": "data",
+      "fraudCheck": "applicable_authoritative_source"
+    }
+  ],
+  "txn": "RB000117420948",
+  "type": "IdentityCheck"
+}
diff --git a/...equests/fraud/kenneth-changed-given-name-and-address-no-applicable/credentialSubject.json b/...equests/fraud/kenneth-changed-given-name-and-address-no-applicable/credentialSubject.json
@@ -0,0 +1,34 @@
+{
+  "address": [
+    {
+      "addressCountry": "GB",
+      "uprn": 100120012047,
+      "buildingName": "",
+      "streetName": "King Road",
+      "postalCode": "BS9 6NR",
+      "buildingNumber": "28",
+      "addressLocality": "BRISTOL",
+      "validFrom": "1000-01-01",
+      "subBuildingName": ""
+    }
+  ],
+  "name": [
+    {
+      "nameParts": [
+        {
+          "type": "GivenName",
+          "value": "KEN"
+        },
+        {
+          "type": "FamilyName",
+          "value": "DECERQUEIRA"
+        }
+      ]
+    }
+  ],
+  "birthDate": [
+    {
+      "value": "1965-07-08"
+    }
+  ]
+}
diff --git a/...ri-stub-requests/fraud/kenneth-changed-given-name-and-address-no-applicable/evidence.json b/...ri-stub-requests/fraud/kenneth-changed-given-name-and-address-no-applicable/evidence.json
@@ -0,0 +1,10 @@
+{
+  "failedCheckDetails": [
+    {
+      "checkMethod": "data",
+      "fraudCheck": "applicable_authoritative_source"
+    }
+  ],
+  "txn": "RB000117420948",
+  "type": "IdentityCheck"
+}
diff --git a/api-tests/data/cri-stub-requests/fraud/kenneth-no-applicable/credentialSubject.json b/api-tests/data/cri-stub-requests/fraud/kenneth-no-applicable/credentialSubject.json
@@ -0,0 +1,32 @@
+{
+  "address": [
+    {
+      "addressCountry": "GB",
+      "buildingName": "",
+      "streetName": "HADLEY ROAD",
+      "postalCode": "BA2 5AA",
+      "buildingNumber": "8",
+      "addressLocality": "BATH",
+      "subBuildingName": ""
+    }
+  ],
+  "name": [
+    {
+      "nameParts": [
+        {
+          "type": "GivenName",
+          "value": "KENNETH"
+        },
+        {
+          "type": "FamilyName",
+          "value": "DECERQUEIRA"
+        }
+      ]
+    }
+  ],
+  "birthDate": [
+    {
+      "value": "1965-07-08"
+    }
+  ]
+}
diff --git a/api-tests/data/cri-stub-requests/fraud/kenneth-no-applicable/evidence.json b/api-tests/data/cri-stub-requests/fraud/kenneth-no-applicable/evidence.json
@@ -0,0 +1,10 @@
+{
+  "failedCheckDetails": [
+    {
+      "checkMethod": "data",
+      "fraudCheck": "applicable_authoritative_source"
+    }
+  ],
+  "txn": "RB000117420948",
+  "type": "IdentityCheck"
+}
diff --git a/api-tests/features/p2-international-journey.feature b/api-tests/features/p2-international-journey.feature
@@ -32,7 +32,7 @@ Feature: P2 App journey
     Then I get an OAuth response
     When I use the OAuth response to get my identity
 
-  Scenario: Successful P2 identity via DCMAW using passport
+  Scenario: Successful P2 international identity via DCMAW using passport
     When I submit an 'international' event
     Then I get a 'non-uk-app-intro' page response
     When I submit a 'useApp' event
@@ -45,12 +45,13 @@ Feature: P2 App journey
       | Attribute | Values               |
       | context   | "international_user" |
     Then I get a 'fraud' CRI response
-    When I submit 'kenneth-score-2' details to the CRI stub
+    When I submit 'kenneth-no-applicable' details to the CRI stub
     Then I get a 'page-ipv-success' page response
     When I submit a 'next' event
     Then I get an OAuth response
     When I use the OAuth response to get my identity
     Then I get a 'P2' identity
+    And I get 'fraud-check-unavailable' return codes
     And an 'IPV_IDENTITY_ISSUED' audit event was recorded [local only]
 
   Scenario: User looks for alternative methods to prove identity without using the app

diff --git a/api-tests/features/reuse-update-details/p2-reuse-update-details-international.feature b/api-tests/features/reuse-update-details/p2-reuse-update-details-international.feature
@@ -1,47 +1,47 @@
 @Build
-Feature: Identity reuse update details
+Feature: International identity reuse update details
 
     Background:
         Given the subject already has the following credentials
-            | CRI     | scenario                     |
-            | dcmaw   | kenneth-driving-permit-valid |
-            | address | kenneth-current              |
-            | fraud   | kenneth-score-2              |
+            | CRI     | scenario               |
+            | dcmaw   | kenneth-passport-valid |
+            | address | kenneth-current        |
+            | fraud   | kenneth-no-applicable   |
         When I start a new 'medium-confidence' journey
-        And I activate the 'internationalAddress' feature sets
         Then I get a 'page-ipv-reuse' page response
-        When I submit a 'update-details' event
+        When I activate the 'internationalAddress' feature sets
+        And I submit a 'update-details' event
         Then I get a 'update-details' page response
 
-    Scenario: Address Change
+    Scenario: International Address Change
         When I submit a 'address-only' event
         Then I get a 'address' CRI response
         When I submit 'kenneth-changed' details with attributes to the CRI stub
             | Attribute | Values               |
             | context   | "international_user" |
         Then I get a 'fraud' CRI response
-        When I submit 'kenneth-score-2' details to the CRI stub
+        When I submit 'kenneth-no-applicable' details to the CRI stub
         Then I get a 'page-ipv-success' page response with context 'updateIdentity'
         When I submit a 'next' event
         Then I get an OAuth response
         When I use the OAuth response to get my identity
         Then I get a 'P2' identity
         And my address 'buildingNumber' is '28'
 
-    Scenario: Address and Family Name Change
+    Scenario: International Address and Family Name Change
         When I submit a 'family-name-and-address' event
         Then I get a 'page-update-name' page response
         When I submit a 'update-name' event
         Then I get a 'dcmaw' CRI response
-        When I submit 'kenneth-changed-family-name-driving-permit-valid' details to the CRI stub
+        When I submit 'kenneth-changed-family-name-passport-valid' details to the CRI stub
         Then I get a 'page-dcmaw-success' page response with context 'coiAddress'
         When I submit a 'next' event
         Then I get a 'address' CRI response
         When I submit 'kenneth-changed' details with attributes to the CRI stub
             | Attribute | Values               |
             | context   | "international_user" |
         Then I get a 'fraud' CRI response
-        When I submit 'kenneth-changed-family-name-score-2' details to the CRI stub
+        When I submit 'kenneth-changed-family-name-and-address-no-applicable' details to the CRI stub
         Then I get a 'page-ipv-success' page response with context 'updateIdentity'
         When I submit a 'next' event
         Then I get an OAuth response
@@ -50,20 +50,20 @@ Feature: Identity reuse update details
         And my identity 'FamilyName' is 'Smith'
         And my address 'addressLocality' is 'Bristol'
 
-    Scenario: Address and Given Name Change
+    Scenario: International Address and Given Name Change
         When I submit a 'given-names-and-address' event
         Then I get a 'page-update-name' page response
         When I submit a 'update-name' event
         Then I get a 'dcmaw' CRI response
-        When I submit 'kenneth-changed-given-name-driving-permit-valid' details to the CRI stub
+        When I submit 'kenneth-changed-given-name-passport-valid' details to the CRI stub
         Then I get a 'page-dcmaw-success' page response with context 'coiAddress'
         When I submit a 'next' event
         Then I get a 'address' CRI response
         When I submit 'kenneth-changed' details with attributes to the CRI stub
             | Attribute | Values               |
             | context   | "international_user" |
         Then I get a 'fraud' CRI response
-        When I submit 'kenneth-changed-given-name-score-2' details to the CRI stub
+        When I submit 'kenneth-changed-given-name-and-address-no-applicable' details to the CRI stub
         Then I get a 'page-ipv-success' page response with context 'updateIdentity'
         When I submit a 'next' event
         Then I get an OAuth response

diff --git a/api-tests/package-lock.json b/api-tests/package-lock.json
diff --git a/api-tests/package.json b/api-tests/package.json
@@ -14,19 +14,19 @@
     "lint-fix": "eslint --fix . && prettier . --write"
   },
   "devDependencies": {
-    "@cucumber/cucumber": "^11.1.0",
-    "@govuk-one-login/data-vocab": "^1.7.2",
-    "@types/eslint__js": "^8.42.3",
-    "dotenv": "^16.4.5",
-    "eslint": "^8.57.0",
-    "eslint-config-prettier": "^9.1.0",
-    "jose": "^5.9.2",
-    "jsonschema": "^1.4.1",
+    "@cucumber/cucumber": "11.1.0",
+    "@govuk-one-login/data-vocab": "1.9.0",
+    "@types/eslint__js": "8.42.3",
+    "dotenv": "16.4.5",
+    "eslint": "8.57.0",
+    "eslint-config-prettier": "9.1.0",
+    "jose": "5.9.2",
+    "jsonschema": "1.4.1",
     "prettier": "3.4.1",
-    "start-server-and-test": "^2.0.4",
-    "ts-node": "^10.9.2",
-    "typescript": "^5.7.2",
-    "typescript-eslint": "^8.18.0",
-    "yaml": "^2.6.0"
+    "start-server-and-test": "2.0.4",
+    "ts-node": "10.9.2",
+    "typescript": "5.7.2",
+    "typescript-eslint": "8.18.0",
+    "yaml": "2.6.0"
   }
 }
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -18,7 +18,7 @@ awsSdkSqs = { module = "software.amazon.awssdk:sqs" }
 awsSdkUrlConnectionClient = { module = "software.amazon.awssdk:url-connection-client" }
 commonsCodec = "commons-codec:commons-codec:1.17.0"
 commonsCollections = "org.apache.commons:commons-collections4:4.5.0-M2"
-diVocab = "uk.gov.di.model:di-data-model-jackson:v1.7.1"
+diVocab = "uk.gov.di.model:di-data-model-jackson:v1.9.0"
 hamcrest = "org.hamcrest:hamcrest:3.0"
 jacksonDatabind = { module = "com.fasterxml.jackson.core:jackson-databind", version.ref = "jackson" }
 jacksonDataformatYaml = { module = "com.fasterxml.jackson.dataformat:jackson-dataformat-yaml", version.ref = "jackson" }