PYIC-7936: remove missed console logs and old test

govuk-one-login · Jan 13, 2025 · 3c9f2c0 · 3c9f2c0
1 parent 48a9db6
commit 3c9f2c0
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/api-tests/features/p2-strategic-app.feature b/api-tests/features/p2-strategic-app.feature
@@ -122,7 +122,6 @@ Feature: M2B Strategic App Journeys
     Then I get a 'non-uk-passport' page response
     When I submit a 'next' event
     Then I get a 'identify-device' page response
-    And an 'IPV_INTERNATIONAL_ADDRESS_START' audit event was recorded [local only]
     When I submit an 'appTriage' event
     Then I get a 'pyi-triage-select-device' page response
     When I submit a 'computer-or-tablet' event

diff --git a/api-tests/src/steps/ipv-steps.ts b/api-tests/src/steps/ipv-steps.ts
@@ -430,8 +430,6 @@ Then(
       const expectedEvents = await getAuditEventsForJourneyType(journeyName);
       const actualEvents = await auditClient.getAuditEvents(this.userId);
 
-      console.log(JSON.stringify(actualEvents));
-
       const comparisonResult = compareAuditEvents(actualEvents, expectedEvents);
       assert.ok(
         comparisonResult.isPartiallyEqual,

diff --git a/api-tests/src/utils/object-matchers.ts b/api-tests/src/utils/object-matchers.ts
@@ -10,12 +10,9 @@ export const comparePartialEqualityBetweenObjects = (
 ): ObjectPartialEqualityResult => {
   for (const [expectedKey, expectedValue] of Object.entries(expectedObject)) {
     if (actualObject[expectedKey] === undefined) {
-      console.log(
-        `Expected ${expectedKey} to be a property in object ${actualObject}`,
-      );
       return {
         isPartiallyEqual: false,
-        errorMessage: `Expected ${expectedKey} to be a property in object ${actualObject}`,
+        errorMessage: `Expected ${expectedKey} to be a property in ${actualObject}`,
       };
     }
 
@@ -35,12 +32,9 @@ export const comparePartialEqualityBetweenObjects = (
     }
 
     if (expectedValue !== actualObject[expectedKey]) {
-      console.log(
-        `Expected ${expectedValue} for index ${expectedKey} but got ${actualObject[expectedKey]}`,
-      );
       return {
         isPartiallyEqual: false,
-        errorMessage: `Expected ${expectedValue} for index ${expectedKey} but got ${actualObject[expectedKey]}`,
+        errorMessage: `Expected ${expectedValue} for field ${expectedKey} but got ${actualObject[expectedKey]}`,
       };
     }
   }