Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clean by event id logic #1059

Merged
merged 2 commits into from
Jan 14, 2025
Merged

add clean by event id logic #1059

merged 2 commits into from
Jan 14, 2025

Conversation

adnahassan
Copy link
Contributor

@adnahassan adnahassan commented Jan 13, 2025

Update clean stage layer script to be able to remove individual events from the stage layer by event name or by multiple event ids. It gets the s3 file the event is in, filters the file and removes the entries that correspond to the associated event id, creates a new file with the new filtered events and uploads it, then deletes the old file.

If cleaning by event name: filters the files in the stage layer key values table that have an event id associated to the event name and uploads new ones, and then removes all of the files from the stage layer table for the event name

if cleaning by event id: filters the files in the stage layer key values table that have the event ids that we want to remove and then uploads new ones, and then filters the files in the stage layer table that have the event ids that we want to remove and then uploads new ones

Image 14-01-2025 at 10 51

before:
Image 14-01-2025 at 11 00

after:
Image 14-01-2025 at 11 00

@adnahassan adnahassan marked this pull request as ready for review January 14, 2025 11:04
@adnahassan adnahassan requested review from a team as code owners January 14, 2025 11:04
Copy link
Contributor

@pradeep-swamireddy-gov pradeep-swamireddy-gov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adnahassan adnahassan merged commit 048fc78 into main Jan 14, 2025
2 checks passed
@adnahassan adnahassan deleted the clean-stage branch January 14, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants