Remove temporary debug logging

Also increase lambda memory and timeout
govuk-one-login · Oct 16, 2023 · b7826be · b7826be
1 parent 9aefebb
commit b7826be
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/iac/resources/quicksight-access.yml b/iac/resources/quicksight-access.yml
@@ -20,7 +20,8 @@ QuicksightAccessLambdaFunction:
         COGNITO_DOMAIN: !Sub https://${QuicksightAccessUserPoolDomain}.auth.${AWS::Region}.amazoncognito.com
     Tags:
       Environment: !Ref Environment
-    Timeout: 10
+    Timeout: 20
+    MemorySize: 512
     # this lambda lives in the protected subnets of a different VPC than the other lambdas
     # because it needs (limited) internet access to call cognito and quicksight APIs and these services do not have VPC endpoints
     # see https://govukverify.atlassian.net/wiki/spaces/PLAT/pages/3531735041/VPC

diff --git a/src/handlers/cognito-quicksight-access/handler.ts b/src/handlers/cognito-quicksight-access/handler.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import { getLogger } from '../../shared/powertools';
 import type { APIGatewayProxyEventV2, APIGatewayProxyResultV2 } from 'aws-lambda';
 import { quicksightClient } from '../../shared/clients';
@@ -30,10 +29,7 @@ export interface UserInfoResponse {
 }
 
 export const handler = async (event: APIGatewayProxyEventV2): Promise<APIGatewayProxyResultV2> => {
-  console.warn({ event });
-  console.warn({ region, cci: process.env.COGNITO_CLIENT_ID, cd: process.env.COGNITO_DOMAIN });
   const code = event?.queryStringParameters?.code;
-  console.warn({ code });
   if (code === null || code === undefined || code.length === 0) {
     return {
       statusCode: 400,
@@ -45,11 +41,8 @@ export const handler = async (event: APIGatewayProxyEventV2): Promise<APIGateway
 
   try {
     const tokens = await callTokenEndpoint(event.requestContext.domainName, code);
-    console.warn({ tokens });
     const userInfo = await callUserInfoEndpoint(tokens);
-    console.warn({ userInfo });
     const embedUrl = await getEmbedUrl(event.requestContext.accountId, userInfo.username);
-    console.warn({ embedUrl });
     return {
       statusCode: 302, // temporary redirect (instead of permanent 301) to avoid browser caching
       headers: {
@@ -74,7 +67,6 @@ const callTokenEndpoint = async (apiGatewayDomainName: string, code: string): Pr
     redirect_uri: `https://${apiGatewayDomainName}`,
     code,
   });
-  console.warn('calling token endpoint', url, body.toString());
 
   const response = await fetch(url, {
     method: 'POST',
@@ -90,7 +82,6 @@ const callTokenEndpoint = async (apiGatewayDomainName: string, code: string): Pr
 // see https://docs.aws.amazon.com/cognito/latest/developerguide/userinfo-endpoint.html
 const callUserInfoEndpoint = async (tokens: TokenResponse): Promise<UserInfoResponse> => {
   const url = `${getCognitoDomain()}/oauth2/userInfo`;
-  console.warn('calling userInfo endpoint', url, `Bearer ${tokens.access_token}`);
 
   const response = await fetch(url, {
     method: 'GET',
@@ -130,7 +121,6 @@ const getEmbedUrl = async (accountId: string, username: string): Promise<string>
   });
 
   try {
-    console.warn('calling quicksight', request.input);
     return await makeUrlRequest(request);
   } catch (error) {
     throw new Error(