BAU: Fix use of .env file for the dev-x.js stubs #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dev-x.js files use dotenv to load environment variables. Therefore, they expect a .env file to exist in the /app directory in the Docker container. We weren't copying in the .env file, so the scripts were always falling back onto default values.
There were two issues previously: 1) We set the 'maxAge' as a datetime 1 hour in the future. This didn't have the intended effect though, as maxAge expects an integer of milliseconds, not a date as we were providing. 'expire' should be used to set expiry at a specific datetime. 2) This is a moot point now though. The session expiry was hardcoded to an hour in the future. Now, it uses the SESSION_EXPIRY param as defined in the .env file. The 'lng' cookie is still set to a year in the future, but that's because a library we use overwrites it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This contains two changes:
Fix .env file not being read into dev-x local stubs
The dev-x.js files use dotenv to load environment variables. Therefore, they expect a .env file to exist in the /app directory in the Docker container. We weren't copying in the .env file, so the scripts were always falling back onto default values.
dev-x stubs use SESSION_EXPIRY as defined in .env file
There were two issues previously:
The 'lng' cookie is still set to a year in the future, but that's because a library we use overwrites it.
How to review