AUT-3921: Change content for mfa reset with IPV #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alhcomer
force-pushed
the
AUT-3921/mfa-with-ipv-content-change
branch
7 times, most recently
from
8a3299e to
aec4645
Compare
alhcomer
force-pushed
the
AUT-3921/mfa-with-ipv-content-change
branch
from
aec4645 to
243a907
Compare
alhcomer
changed the title
|
alhcomer
changed the title
BeckaL
reviewed
Jan 16, 2025
| <a href={{ mfaResetPath }} class="govuk-link" | ||
| rel="noreferrer noopener">{{ 'pages.enterMfa.details.changeGetSecurityCodesLinkText'| translate }}</a>. | ||
| </p> | ||
| {% if supportAccountRecovery === true or supportAccountRecovery === "true" %} |
There was a problem hiding this comment.
This looks like a repeated line
| rel="noreferrer noopener">{{ 'pages.enterMfa.details.changeGetSecurityCodesLinkText'| translate }}</a>. | ||
| </p> | ||
| {% if supportAccountRecovery === true or supportAccountRecovery === "true" %} | ||
| {% if supportMfaResetWithIpv === true or supportMfaResetWithIpv === "true" %} |
There was a problem hiding this comment.
I assume you need to add this as a hidden input also - does the wrong thing appear if you refresh the page?
There was a problem hiding this comment.
Just did a quick test and doesn't seem to make a difference, which makes me wonder if we're doing an amount of this cacheing unnecessarily. Worth verifying on your side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Made content changes for MFA screens to reflect that MFA relies on approval from IPV.
SMS MFA:
AUTH APP MFA:
Changes to the acceptance tests have been made to reflect these changes. They are commented out currently, to be uncommented when MFA_RESET_WITH_IPV is turned on.
Happy for this to be merged in my absence if no changes need to be made.
How to review
Check that for SMS you see: 'If you no longer have access to this phone number, check if you can change how you get security codes.'
Check that for AUTH_APP you see: 'If you no longer have access to your authenticator app, check if you can change how you get security codes.'
Checklist
Related PRs